Fix tests that fail with browser.proton.contextmenus.enabled
Categories
(Firefox :: Menus, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: Gijs, Assigned: enndeakin)
References
Details
Attachments
(1 file)
https://treeherder.mozilla.org/jobs?repo=try&revision=ed2bdd264727e17c7b790a68167b40051666275c
It's not as bad as it looks, most of those failures are for proton tabs related tests. However, I think the following failures relate to our new context menu work:
- all the Win10
toolkit/content/tests/chrome/mochitest-chrome-1proc failures. There's quite a few of these. - browser/base/content/test/forms/browser_selectpopup.js
- browser/base/content/test/forms/browser_selectpopup_colors.js
We'll need to fix these in order to graduate the context menu work behind the main proton pref and then be able to enable it.
|
Assignee | |
Comment 1•3 years ago
|
||
I have fixes for browser_selectpopup.js and most of the toolkit/content/tests/chrome/ ones.
The browser_selectpopup_colors.js seems to depend on the colours so I'll need to take a closer look at it.
|
Reporter | |
Comment 2•3 years ago
|
||
(In reply to Neil Deakin from comment #1)
The browser_selectpopup_colors.js seems to depend on the colours so I'll need to take a closer look at it.
I've been looking at it today given that I recently fixed bug 1699399. I've had limited success so far but I can probably get it sorted tomorrow.
|
|
Reporter | |
Comment 3•3 years ago
|
||
(In reply to :Gijs (he/him) from comment #2)
(In reply to Neil Deakin from comment #1)
The browser_selectpopup_colors.js seems to depend on the colours so I'll need to take a closer look at it.
I've been looking at it today given that I recently fixed bug 1699399. I've had limited success so far but I can probably get it sorted tomorrow.
I clearly jinxed it, but I've split it off to bug 1702258. We can use this bug for the other tests.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Account for the border and padding now on the inner arrowscrollbox, and increase some window and margin
sizes to account for the menu being larger in Windows 10.
|
|
Reporter | |
Comment 5•3 years ago
|
||
Can this land or would it make tests fail before we flip the default value of the pref?
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27b360c82c4a fix some menu related tests on Windows 10 that fail with the larger menu size, r=Gijs
|
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Description
•