1702001 - Can't load careers.aliceapp.com in https only mode

Status: VERIFIED FIXED

(Core :: DOM: Security, defect, P1)

Description

[Asif Youssuff]

Steps to reproduce:

1. Set dom.security.https_only_mode to true
2. Navigate to http://careers.aliceapp.com/apply/haxr79rjWf/Director-Of-Product?source=LILI#haxr79rjWf
3. Click "Continue to HTTP Site"

What happens:

Nothing. Page is not navigated to.

Expected result:

Page is navigated to.

5:10.15 INFO: Narrowed integration regression window from [098c3172, f40c23dc] (3 builds) to [098c3172, 5648a425] (2 builds) (~1 steps left)
5:10.15 INFO: No more integration revisions, bisection finished.
5:10.15 INFO: Last good revision: 098c3172afae38b129ae08e1586499f698a816f3
5:10.15 INFO: First bad revision: 5648a4254bca91c97b2ae625cf06270f1fc0ff8d
5:10.15 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=098c3172afae38b129ae08e1586499f698a816f3&tochange=5648a4254bca91c97b2ae625cf06270f1fc0ff8d

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Tomer, can you please take a look?

Comment 2

[Tomer Yavor]

Yes,
I will check why that bug appears.
Thank you for reporting.

Comment 3

[Tomer Yavor]

It appears because it is detecting that it is the same origin except of the protocol. So it is interpreted as a navigation link and not as a reload request in http. I will fix it.

Comment 4

[Tomer Yavor]

Attachment: Bug 1702001 Https-only mode does not reload pages after clicking "Continue to HTTP Site", when url contains navigation

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1694932

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b09095eaf7d9
Https-only mode does not reload pages after clicking "Continue to HTTP Site", when url contains navigation r=ckerschb

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on test_insecure_reload.html

backout: https://hg.mozilla.org/integration/autoland/rev/270452ec3b642d47ba9ed7ce813e8c55886c2281

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=b09095eaf7d92f84b34daf095a36e7056efe8381&group_state=expanded&selectedTaskRun=WefV--JLTDqOMNj1NfHmbg.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=335810176&repo=autoland&lineNumber=2818

[task 2021-04-08T08:59:36.299Z] 08:59:36     INFO -  TEST-PASS | dom/security/test/https-only/test_insecure_reload.html | Reason cannot be empty
[task 2021-04-08T08:59:36.299Z] 08:59:36     INFO -  TEST-FAIL | dom/security/test/https-only/test_insecure_reload.html | The author of the test has indicated that flaky timeouts are expected.  Reason: We need to wait for the HTTPS-Only error page to appear
[task 2021-04-08T08:59:36.299Z] 08:59:36     INFO -  Buffered messages finished
[task 2021-04-08T08:59:36.300Z] 08:59:36  WARNING -  TEST-UNEXPECTED-FAIL | dom/security/test/https-only/test_insecure_reload.html | the error page should be shown for  - false == true - got false, expected true (operator ==)
[task 2021-04-08T08:59:36.300Z] 08:59:36     INFO -  ok@resource://specialpowers/SpecialPowersSandbox.jsm:87:21
[task 2021-04-08T08:59:36.300Z] 08:59:36     INFO -  verifyErrorPage@http://mochi.test:8888/tests/dom/security/test/https-only/test_insecure_reload.html:41:5
[task 2021-04-08T08:59:36.300Z] 08:59:36     INFO -  execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-08T08:59:36.300Z] 08:59:36     INFO -  _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-08T08:59:36.301Z] 08:59:36     INFO -  receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-08T08:59:36.301Z] 08:59:36  WARNING -  TEST-UNEXPECTED-FAIL | dom/security/test/https-only/test_insecure_reload.html | button exist - null == true - got null, expected true (operator ==)
[task 2021-04-08T08:59:36.301Z] 08:59:36     INFO -  ok@resource://specialpowers/SpecialPowersSandbox.jsm:87:21
[task 2021-04-08T08:59:36.301Z] 08:59:36     INFO -  verifyErrorPage@http://mochi.test:8888/tests/dom/security/test/https-only/test_insecure_reload.html:44:5
[task 2021-04-08T08:59:36.301Z] 08:59:36     INFO -  execute@resource://specialpowers/SpecialPowersSandbox.jsm:141:12
[task 2021-04-08T08:59:36.302Z] 08:59:36     INFO -  _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1604:15
[task 2021-04-08T08:59:36.302Z] 08:59:36     INFO -  receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:310:21
[task 2021-04-08T09:04:39.428Z] 09:04:39  WARNING -  TEST-UNEXPECTED-FAIL | dom/security/test/https-only/test_insecure_reload.html | Test timed out.
[task 2021-04-08T09:04:39.429Z] 09:04:39     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2021-04-08T09:04:39.429Z] 09:04:39     INFO -      reportError@SimpleTest/TestRunner.js:147:24
[task 2021-04-08T09:04:39.429Z] 09:04:39     INFO -      TestRunner._checkForHangs@SimpleTest/TestRunner.js:170:18
[task 2021-04-08T09:04:39.430Z] 09:04:39     INFO -  TEST-OK | dom/security/test/https-only/test_insecure_reload.html | took 312344ms

Comment 8

[Tomer Yavor]

Thanks you, I will review this

Comment 9

[Tomer Yavor]

I think it failed because in firefox on android is no error page for https-only mode.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4033963b1e2d
Https-only mode does not reload pages after clicking "Continue to HTTP Site", when url contains navigation r=ckerschb

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4033963b1e2d

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 89.0a1 (20210330215136) on Windows 10x64.
The issue is verified fixed with Firefox 89.0b3 (20210422190146) on Windows 10x64 and macOS 11.2.3. The page is loaded after following steps from comment 0.