Closed Bug 1702036 Opened 3 years ago Closed 3 years ago

Intermittent [TV] browser/components/places/tests/browser/browser_bookmark_remove_tags.js | Bookmark panel title is correct. - "" == "Edit Bookmark" - JS frame :: chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_...

Categories

(Firefox :: Bookmarks & History, defect, P5)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: standard8)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1702036 - Fix intermittent in browser_bookmark_remove_tags.js. Check the id, not the fluent string. r?mak!
48 bytes, text/x-phabricator-request
Details | Review

Filed by: dluca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=334930537&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CVb5M1-kSGGIgXGsWk0veQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CVb5M1-kSGGIgXGsWk0veQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

INFO - TEST-START | browser/components/places/tests/browser/browser_bookmark_remove_tags.js
[task 2021-03-30T18:31:55.948Z] 18:31:55     INFO - GECKO(3252) | Waiting for browser load
[task 2021-03-30T18:31:55.949Z] 18:31:55     INFO - GECKO(3252) | Waiting for browser state change
[task 2021-03-30T18:31:56.045Z] 18:31:56     INFO - GECKO(3252) | Saw state 110001 and status 0
[task 2021-03-30T18:31:56.274Z] 18:31:56     INFO - GECKO(3252) | Saw state c0010 and status 0
[task 2021-03-30T18:31:56.274Z] 18:31:56     INFO - GECKO(3252) | Browser got expected state change about:buildconfig
[task 2021-03-30T18:31:56.512Z] 18:31:56     INFO - TEST-INFO | started process screentopng
[task 2021-03-30T18:31:56.701Z] 18:31:56     INFO - TEST-INFO | screentopng: exit 0
[task 2021-03-30T18:31:56.702Z] 18:31:56     INFO - Buffered messages logged at 18:31:55
[task 2021-03-30T18:31:56.703Z] 18:31:56     INFO - Entering test bound setup
[task 2021-03-30T18:31:56.703Z] 18:31:56     INFO - Global property added while loading chrome://browser/content/places/browserPlacesViews.js: PlacesViewBase
[task 2021-03-30T18:31:56.704Z] 18:31:56     INFO - Leaving test bound setup
[task 2021-03-30T18:31:56.704Z] 18:31:56     INFO - Entering test bound test_remove_tags_from_BookmarkStar
[task 2021-03-30T18:31:56.705Z] 18:31:56     INFO - Buffered messages finished
[task 2021-03-30T18:31:56.705Z] 18:31:56     INFO - TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | Bookmark panel title is correct. - "" == "Edit Bookmark" - JS frame :: chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmark_remove_tags.js :: test_remove_tags_from_BookmarkStar :: line 56
[task 2021-03-30T18:31:56.706Z] 18:31:56     INFO - Stack trace:
[task 2021-03-30T18:31:56.707Z] 18:31:56     INFO - chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_bookmark_remove_tags.js:test_remove_tags_from_BookmarkStar:56
[task 2021-03-30T18:31:56.707Z] 18:31:56     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“r” modifiers=“accel,alt” id=“key_toggleReaderMode”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1280}]
[task 2021-03-30T18:31:56.708Z] 18:31:56     INFO - Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox”" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 1280}]
[task 2021-03-30T18:31:56.709Z] 18:31:56     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | Should have updated the bookmark tags in the database. - ["tag1","tag2","tag3"] deepEqual ["tag1","tag2","tag3"] - 
[task 2021-03-30T18:31:56.710Z] 18:31:56     INFO - Leaving test bound test_remove_tags_from_BookmarkStar
[task 2021-03-30T18:31:56.710Z] 18:31:56     INFO - Entering test bound test_remove_tags_from_Toolbar
[task 2021-03-30T18:31:56.741Z] 18:31:56     INFO - withBookmarksDialog: opening the dialog
[task 2021-03-30T18:31:56.743Z] 18:31:56     INFO - withBookmarksDialog: waiting for the dialog
[task 2021-03-30T18:31:57.160Z] 18:31:57     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | The bookmark properties dialog is open: chrome://browser/content/places/bookmarkProperties.xhtml - 
[task 2021-03-30T18:31:57.161Z] 18:31:57     INFO - must wait for focus
[task 2021-03-30T18:31:57.220Z] 18:31:57     INFO - waiting for the overlay to be loaded
[task 2021-03-30T18:31:57.220Z] 18:31:57     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | There should be an input to focus. - 
[task 2021-03-30T18:31:57.220Z] 18:31:57     INFO - waiting for focus on the first textfield
[task 2021-03-30T18:31:57.220Z] 18:31:57     INFO - withBookmarksDialog: executing the task
[task 2021-03-30T18:31:57.220Z] 18:31:57     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | Tags are correct before update. - "tag1, tag2, tag3" == "tag1, tag2, tag3" - 
[task 2021-03-30T18:31:57.268Z] 18:31:57     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | Should have updated the bookmark tags in the database. - ["tag1","tag2"] deepEqual ["tag1","tag2"] - 
[task 2021-03-30T18:31:57.417Z] 18:31:57     INFO - Leaving test bound test_remove_tags_from_Toolbar
[task 2021-03-30T18:31:57.417Z] 18:31:57     INFO - Entering test bound test_remove_tags_from_Sidebar
[task 2021-03-30T18:31:57.419Z] 18:31:57     INFO - withSidebarTree: waiting sidebar load
[task 2021-03-30T18:31:57.747Z] 18:31:57     INFO - withSidebarTree: executing the task
[task 2021-03-30T18:31:57.748Z] 18:31:57     INFO - withBookmarksDialog: opening the dialog
[task 2021-03-30T18:31:57.749Z] 18:31:57     INFO - withBookmarksDialog: waiting for the dialog
[task 2021-03-30T18:31:58.071Z] 18:31:58     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | The bookmark properties dialog is open: chrome://browser/content/places/bookmarkProperties.xhtml - 
[task 2021-03-30T18:31:58.072Z] 18:31:58     INFO - must wait for focus
[task 2021-03-30T18:31:58.148Z] 18:31:58     INFO - waiting for the overlay to be loaded
[task 2021-03-30T18:31:58.148Z] 18:31:58     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | There should be an input to focus. - 
[task 2021-03-30T18:31:58.148Z] 18:31:58     INFO - waiting for focus on the first textfield
[task 2021-03-30T18:31:58.149Z] 18:31:58     INFO - withBookmarksDialog: executing the task
[task 2021-03-30T18:31:58.149Z] 18:31:58     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | Tags are correct before update. - "tag1, tag2" == "tag1, tag2" - 
[task 2021-03-30T18:31:58.184Z] 18:31:58     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | Should have updated the bookmark tags in the database. - ["tag1"] deepEqual ["tag1"] - 
[task 2021-03-30T18:31:58.320Z] 18:31:58     INFO - Leaving test bound test_remove_tags_from_Sidebar
[task 2021-03-30T18:31:58.580Z] 18:31:58     INFO - TEST-PASS | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | All the wait timers have been removed - 
[task 2021-03-30T18:31:58.656Z] 18:31:58     INFO - GECKO(3252) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2021-03-30T18:31:58.657Z] 18:31:58     INFO - GECKO(3252) | MEMORY STAT | vsize 3132MB | residentFast 329MB | heapAllocated 122MB
[task 2021-03-30T18:31:58.657Z] 18:31:58     INFO - TEST-OK | browser/components/places/tests/browser/browser_bookmark_remove_tags.js | took 2884ms
[task 2021-03-30T18:31:58.698Z] 18:31:58     INFO - checking window state
[task 2021-03-30T18:31:58.766Z] 18:31:58     INFO - TEST-START | browser/components/places/tests/browser/browser_bookmark_remove_tags.js```

Set release status flags based on info from the regressing bug 1697507

status-firefox87: --- → unaffected
status-firefox88: --- → unaffected
status-firefox89: --- → affected
status-firefox-esr78: --- → unaffected

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE

This still happens, it appears to be testing the translated value of the string, using fluent. My guess is that Fluent hasn't actually updated the DOM when we run the check. Changing to test the id rather than the string seems to work fine.

Assignee: nobody → standard8
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a633c33737c
Fix intermittent in browser_bookmark_remove_tags.js. Check the id, not the fluent string. r=mak

https://hg.mozilla.org/mozilla-central/rev/9a633c33737c

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: