1697507 - Apply Proton styles to Bookmarks panel when Proton is enabled

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

This means the Proton-style buttons at the bottom of the panel, some changes to padding and spacing, and changes to the styles of the various form fields in the panel. Details to be supplied shortly.

Comment 1

[Romain Testard [:RT]]

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I'm starting this now.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1697507 - Restyle bookmarks panel for Proton. r?harry!

This updates the styling of the Bookmarks Panel for Proton, and also:

• Fixes menulist sizes on macOS to be 32px tall for size="large", per spec
• Makes text input elements in panels be 32px tall, per spec

Comment 5

[Mike Conley (:mconley) (:⚙️)]

ni?ing harry for https://phabricator.services.mozilla.com/D109638#3575712

Comment 6

[Harry Twyford]

r+!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83a561e6c1d0
Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry

Comment 8

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1697507, bug 1697491) for Browser-chrome in browser/components/places/tests/browser/browser_bookmark_remove_tags.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=334920660&repo=autoland&lineNumber=2501

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=83a561e6c1d089938fb60f2839178824f45dafce

Backout:
https://hg.mozilla.org/integration/autoland/rev/01f21a71b04499593452ec10d104544340f2ec02

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c83e6038430
Restyle bookmarks panel for Proton. r=desktop-theme-reviewers,harry

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4c83e6038430

Comment 11

[Anje]

Is this bug responsible for the huge expanses of blank space between Bookmark menu items, so forcing loads of uncessary scrolling and making life difficult for people suffereing from RSI ?

If yes, then please supply information so it can be fixed.
I had fixed this defect in design by forcing all preference references to 'proton' as 'false', but something is bypassing this in version 91 and the Support Forum is starting to ask for solution.