1702117 - Remove CFR strings using -sync-brand-short-name

Status: RESOLVED FIXED

(Firefox :: Messaging System, task)

Description

[Francesco Lodolo [:flod]]

With MR1 we're getting rid of Sync intended as a feature name, and all the brand strings used across Firefox.

These have all been updated or removed in bug 1700638, but there are still two strings in asrouter.ftl

cfr-doorhanger-sync-bookmarks-ok-button = Turn on { -sync-brand-short-name }
cfr-doorhanger-sync-logins-ok-button = Turn on { -sync-brand-short-name }

I didn't touch them, because the guideline from product is that CFR will be removed as a whole. I understand that requires a considerable amount of work, but would it be possible to at least remove these two CFRs, so that we can also remove the brand from tree?
https://searchfox.org/mozilla-central/search?q=-sync-brand-short-name

Comment 1

[Punam Dahiya [:pdahiya]]

NI @andrei to help confirm if its safe to remove these two strings in Fx89

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Bug 1702117 - Remove CFR strings using -sync-brand-short-name

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ac2582ca447
Remove CFR strings using -sync-brand-short-name r=pdahiya,fluent-reviewers,flod

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2ac2582ca447