Closed Bug 1702118 Opened 4 years ago Closed 4 years ago

Move more strings for the FxA toolbar button to Fluent

Categories

(Firefox :: Menus, task)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: flod, Assigned: flod)

Details

Attachments

(1 file)

My main target is to get rid of the syncBrand.fxAccount.label DTD entity. This button is currently one of the two users, the other is being removed in bug 1700972.

There are at least two other static strings that seem easy to port, one other seems more complex and I might leave it behind.

A couple more notes:

  • The tooltip and name of the icon in customize mode should now say "Firefox account" (lowercase account), per Betsy's guidelines.
  • I tried looking into migrating other strings which don't seem attached to JS code. The issue is figuring out where they are used, and which state triggers them. Sadly it will require too much time for me to figure it out. I have the feeling that migrating them to Fluent will require a lot of splitting, and someone familiar with the code/states.
Attachment #9212718 - Attachment description: Bug 1702118 - Migrate more FxA toolbar button strings to Fluent, r=mconley! → Bug 1702118 - Migrate more FxA toolbar button strings to Fluent, r=gijs!
Pushed by flodolo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c8d54305f5a Migrate more FxA toolbar button strings to Fluent, r=fluent-reviewers,Gijs
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: