Closed Bug 1702125 Opened 4 years ago Closed 4 years ago

Clicked state on Oveflow menu button is not kept when opening context menus for the items in it

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Product:
Firefox
Component:
Toolbars and Customization
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- verified

People

(Reporter: csasca, Assigned: mconley)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, regressionwindow-wanted, Whiteboard: [proton-toolbar])

Attachments

(1 file)

Bug 1702125 - Only automatically add/remove open state on buttons on anchored arrowpanel events. r?Gijs!
48 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • Firefox 89.0a1

Affected platforms

  • macOS 10.15.7
  • Windows 10
  • Ubuntu 20.04

Steps to reproduce

  1. Launch Firefox
  2. Add some items to the overflow menu
  3. Click on overflow menu to open it
  4. Right click a couple of times over the items in the list

Expected result

  • The clicked state is kept on the overflow menu button

Actual result

  • The clicked state is not kept on the overflow menu button

Regression range

  • Will see for a regression

Additional notes

  • The issue can be seen in the following attachment
Has Regression Range: --- → no
Has STR: --- → yes
Priority: -- → P3

I haven't checked for regression range but the code responsible for removing "open" attribute from the button (which is how CSS know when to style it as focused) in this case was added in bug 1701664 here:
https://searchfox.org/mozilla-central/rev/9043e515e9608cc55b252a40cb2dfb6f767bcffd/toolkit/content/widgets/panel.js#233-237

Keywords: regression
Regressed by: 1701664

Uh, I meant bug 1694285.

Regressed by: 1694285
No longer regressed by: 1701664

Depends on D110811

Assignee: nobody → mconley
Status: NEW → ASSIGNED
Blocks: 1703262
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0e3b97dc503
Only automatically add/remove open state on buttons on anchored arrowpanel events. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/e0e3b97dc503

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified that this issue is fixed on Firefox 89.0a1 (2021-04-14). Tests were performed on macOS 11.2.3, Ubuntu 20.04 and Windows 10.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: