Closed Bug 1702166 Opened 3 years ago Closed 3 years ago

Update ESLint, Babel and associated modules to the latest versions

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

In starting work on bug 1498604, I had to regenerate package-lock.json, which broke ESLint / Babel in various ways due to the parser implementations having changed, and seemingly Babel's module sub-dependencies conflicting when they shouldn't.

The easiest way out of this seems to be to just update everything that we can at the moment - this doesn't hurt anyway, as we've not had an update for a while.

Some notes:

  • Various babel modules have moved to being developed as part of Babel core. Hence the changes to migrate to the @babel/ prefixes.
  • eslint-plugin-jest can't be updated yet, that seems to conflict with the devtools debugger package/top-level set up. It could be that we can just disable one rule, but I've left it out for now.
  • Due to the way the latest babel parser code is working, I'm having to change tools/lint/eslint/eslint-plugin-mozilla/lib/helpers.js to specify the config file to load. I think we can do that mozilla-central only, from a quick test in thunderbird-conversations it works fine that way.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7a73176c8cc
Update ESLint, Babel and associated modules to the latest versions. r=mossop,nchevobbe
Regressions: 1702922
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/bfd3fb15ff9b
adjust comm-central for "Update ESLint, Babel and associated modules to the latest versions". rs=bustage-fix DONTBUILD
Iteration: --- → 89.1 - Mar 22 - Apr 4
No longer regressions: 1702922
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: