1702922 - Perma [tier 2] tools/lint/test/test_clippy.py::test_basic[clippy] | test_file_and_path_provided[clippy] TEST-UNEXPECTED-FAIL

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=335387262&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/AHwWMT4vQJWQbaK1sFv36A/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-04-04T08:49:39.247Z]  0:30.88 tools/lint/test/test_clippy.py::test_file_and_path_provided[clippy] TEST-UNEXPECTED-FAIL
[task 2021-04-04T08:49:39.248Z]  0:30.88 tools/lint/test/test_clippy.py::test_file_provided[clippy] PASSED
[task 2021-04-04T08:49:39.248Z]  0:30.88 tools/lint/test/test_clippy.py::test_cleanup[clippy] PASSED
[task 2021-04-04T08:49:39.248Z]  0:30.88 
[task 2021-04-04T08:49:39.249Z]  0:30.88 =================================== FAILURES ===================================
[task 2021-04-04T08:49:39.249Z]  0:30.88 ______________________________ test_basic[clippy] ______________________________
[task 2021-04-04T08:49:39.249Z]  0:30.88 
[task 2021-04-04T08:49:39.249Z]  0:30.88 lint = <function lint.<locals>.wrapper at 0x7f15da3347b8>
[task 2021-04-04T08:49:39.249Z]  0:30.88 config = {'description': 'Lint rust', 'exclude': ['Cargo.toml', 'gfx/wr/', 'gfx/wr/webrender/', 'gfx/wr/examples/', 'gfx/wr/web...', 'gfx/webrender_bindings/', 'gfx/wr/direct-composition/', 'gfx/wr/example-compositor/compositor-windows/', ...], ...}
[task 2021-04-04T08:49:39.249Z]  0:30.88 paths = <function paths.<locals>._inner at 0x7f15da334730>
[task 2021-04-04T08:49:39.249Z]  0:30.88 
[task 2021-04-04T08:49:39.249Z]  0:30.88     def test_basic(lint, config, paths):
[task 2021-04-04T08:49:39.249Z]  0:30.88         results = lint(paths("test1/"))
[task 2021-04-04T08:49:39.249Z]  0:30.88         print(results)
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert len(results) > 7
[task 2021-04-04T08:49:39.249Z]  0:30.88 
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert (
[task 2021-04-04T08:49:39.249Z]  0:30.88             "is never read" in results[0].message or "but never used" in results[0].message
[task 2021-04-04T08:49:39.249Z]  0:30.88         )
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert results[0].level == "warning"
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert results[0].lineno == 7
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert results[0].column == 9
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert results[0].rule == "unused_assignments"
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert results[0].relpath == "test1/bad.rs"
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert "tools/lint/test/files/clippy/test1/bad.rs" in results[0].path
[task 2021-04-04T08:49:39.249Z]  0:30.88 
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert "this looks like you are trying to swap `a` and `b`" in results[1].message
[task 2021-04-04T08:49:39.249Z]  0:30.88         assert results[1].level == "error"
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert results[1].relpath == "test1/bad.rs"
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert results[1].rule == "clippy::almost_swapped"
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert "or maybe you should use `std::mem::replace`" in results[1].hint
[task 2021-04-04T08:49:39.250Z]  0:30.88 
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert "value assigned to `b` is never read" in results[2].message
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert results[2].level == "warning"
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert results[2].relpath == "test1/bad.rs"
[task 2021-04-04T08:49:39.250Z]  0:30.88 
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert "variable does not need to be mutable" in results[5].message
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert results[5].relpath == "test1/bad2.rs"
[task 2021-04-04T08:49:39.250Z]  0:30.88         assert results[5].rule == "unused_mut"
[task 2021-04-04T08:49:39.250Z]  0:30.88 
[task 2021-04-04T08:49:39.250Z]  0:30.88 >       assert "this range is empty so" in results[6].message
[task 2021-04-04T08:49:39.250Z]  0:30.88 E       AssertionError: assert 'this range is empty so' in 'calls to `push` immediately after creation'
[task 2021-04-04T08:49:39.250Z]  0:30.88 E        +  where 'calls to `push` immediately after creation' = Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs', lineno=8, col...\n', source=None, level='warning', rule='clippy::vec_init_then_push', lineoffset=2, diff=None, relpath='test1/bad2.rs').message
[task 2021-04-04T08:49:39.250Z]  0:30.88 
[task 2021-04-04T08:49:39.250Z]  0:30.88 tools/lint/test/test_clippy.py:36: AssertionError
[task 2021-04-04T08:49:39.250Z]  0:30.88 ----------------------------- Captured stdout call -----------------------------
[task 2021-04-04T08:49:39.251Z]  0:30.88 [Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad.rs', lineno=7, column=9, message='value assigned to `a` is never read', hint='warning: value assigned to `a` is never read\n --> bad.rs:7:9\n  |\n7 |     let mut a=1;\n  |         ^^^^^\n  |\n  = note: `#[warn(unused_assignments)]` on by default\n  = help: maybe it is overwritten before being read?\n\n', source=None, level='warning', rule='unused_assignments', lineoffset=0, diff=None, relpath='test1/bad.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad.rs', lineno=10, column=5, message='this looks like you are trying to swap `a` and `b`', hint='error: this looks like you are trying to swap `a` and `b`\n  --> bad.rs:10:5\n   |\n10 | /     a = b;\n11 | |     b = a;\n   | |_________^ help: try: `std::mem::swap(&mut a, &mut b)`\n   |\n   = note: `#[deny(clippy::almost_swapped)]` on by default\n   = note: or maybe you should use `std::mem::replace`?\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#almost_swapped\n\n', source=None, level='error', rule='clippy::almost_swapped', lineoffset=1, diff=None, relpath='test1/bad.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad.rs', lineno=11, column=5, message='value assigned to `b` is never read', hint='warning: value assigned to `b` is never read\n  --> bad.rs:11:5\n   |\n11 |     b = a;\n   |     ^\n   |\n   = help: maybe it is overwritten before being read?\n\n', source=None, level='warning', rule='unused_assignments', lineoffset=0, diff=None, relpath='test1/bad.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs', lineno=6, column=9, message='variable `a` is assigned to, but never used', hint='warning: variable `a` is assigned to, but never used\n --> bad2.rs:6:9\n  |\n6 |     let mut a;\n  |         ^^^^^\n  |\n  = note: `#[warn(unused_variables)]` on by default\n  = note: consider using `_a` instead\n\n', source=None, level='warning', rule='unused_variables', lineoffset=0, diff=None, relpath='test1/bad2.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs', lineno=7, column=9, message='unused variable: `b`', hint='warning: unused variable: `b`\n --> bad2.rs:7:9\n  |\n7 |     let mut b=1;\n  |         ^^^^^ help: if this is intentional, prefix it with an underscore: `_b`\n\n', source=None, level='warning', rule='unused_variables', lineoffset=0, diff=None, relpath='test1/bad2.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs', lineno=7, column=9, message='variable does not need to be mutable', hint='warning: variable does not need to be mutable\n --> bad2.rs:7:9\n  |\n7 |     let mut b=1;\n  |         ----^\n  |         |\n  |         help: remove this `mut`\n  |\n  = note: `#[warn(unused_mut)]` on by default\n\n', source=None, level='warning', rule='unused_mut', lineoffset=0, diff=None, relpath='test1/bad2.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs', lineno=8, column=5, message='calls to `push` immediately after creation', hint='warning: calls to `push` immediately after creation\n  --> bad2.rs:8:5\n   |\n8  | /     let mut vec = Vec::new();\n9  | |     vec.push(1);\n10 | |     vec.push(2);\n   | |________________^ help: consider using the `vec![]` macro: `let mut vec = vec![..];`\n   |\n   = note: `#[warn(clippy::vec_init_then_push)]` on by default\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push\n\n', source=None, level='warning', rule='clippy::vec_init_then_push', lineoffset=2, diff=None, relpath='test1/bad2.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs', lineno=13, column=14, message='this range is empty so it will yield no values', hint='error: this range is empty so it will yield no values\n  --> bad2.rs:13:14\n   |\n13 |     for x in 5..10 - 5 {\n   |              ^^^^^^^^^\n   |\n   = note: `#[deny(clippy::reversed_empty_ranges)]` on by default\n   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reversed_empty_ranges\n\n', source=None, level='error', rule='clippy::reversed_empty_ranges', lineoffset=0, diff=None, relpath='test1/bad2.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs', lineno=14, column=9, message='value assigned to `a` is never read', hint='warning: value assigned to `a` is never read\n  --> bad2.rs:14:9\n   |\n14 |         a = x;\n   |         ^\n   |\n   = note: `#[warn(unused_assignments)]` on by default\n   = help: maybe it is overwritten before being read?\n\n', source=None, level='warning', rule='unused_assignments', lineoffset=0, diff=None, relpath='test1/bad2.rs')]
[task 2021-04-04T08:49:39.251Z]  0:30.88 ----------------------------- Captured stderr call -----------------------------
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:29.881 clippy (444) | Found CARGO_HOME in /build/rust
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:30.129 clippy (444) | Found version: clippy 0.1.51 (2fd73fa 2021-03-23)
[task 2021-04-04T08:49:39.251Z]  0:30.88 
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:30.129 clippy (444) | Found version: 2021.3.23. Minimal expected version: 2020.5.11
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:30.129 clippy (444) | Path = /builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:30.130 clippy (444) | Path translated to = /builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/Cargo.toml
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:30.130 clippy (444) | Command: ['/build/rust/bin/cargo', 'clean', '--manifest-path', '/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/Cargo.toml']
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:30.335 clippy (444) | Command: ['/build/rust/bin/cargo', 'clippy', '--message-format=json', '--manifest-path', '/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/Cargo.toml']
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:30.987 clippy (444) | Command: ['/build/rust/bin/cargo', 'clean', '--manifest-path', '/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/Cargo.toml']
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:31.132 clippy (444) | Could not parse the output:
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:31.132 clippy (444) | clippy output: b'    Checking hello_world v0.1.0 (/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1)'
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:31.133 clippy (444) | Error outside of clippy.This means that the build failed. Therefore, skipping this
[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:31.133 clippy (444) | File = /builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs / Detail = {'rendered': 'error: aborting due to previous error; 5 warnings emitted\n\n', 'children': [], 'code': None, 'level': 'error', 'message': 'aborting due to previous error; 5 warnings emitted', 'spans': []}
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | Error outside of clippy.This means that the build failed. Therefore, skipping this
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | File = /builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad.rs / Detail = {'rendered': 'error: aborting due to previous error; 2 warnings emitted\n\n', 'children': [], 'code': None, 'level': 'error', 'message': 'aborting due to previous error; 2 warnings emitted', 'spans': []}
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | Could not parse the output:
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | clippy output: b'error: could not compile `hello_world`'
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | Could not parse the output:
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | clippy output: b''
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | Could not parse the output:
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | clippy output: b'To learn more, run the command again with --verbose.'
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | Could not parse the output:
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.133 clippy (444) | clippy output: b'warning: build failed, waiting for other jobs to finish...'
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.134 clippy (444) | Could not parse the output:
[task 2021-04-04T08:49:39.252Z]  0:30.88 08:49:31.134 clippy (444) | clippy output: b'error: build failed'
[task 2021-04-04T08:49:39.252Z]  0:30.88 ------------------------------ Captured log call -------------------------------
[task 2021-04-04T08:49:39.252Z]  0:30.88 __init__.py                106 DEBUG    Found CARGO_HOME in /build/rust
[task 2021-04-04T08:49:39.252Z]  0:30.88 __init__.py                129 DEBUG    Found version: clippy 0.1.51 (2fd73fa 2021-03-23)
[task 2021-04-04T08:49:39.253Z]  0:30.88 
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                175 DEBUG    Found version: 2021.3.23. Minimal expected version: 2020.5.11
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                217 DEBUG    Path = /builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                234 DEBUG    Path translated to = /builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/Cargo.toml
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                149 DEBUG    Command: ['/build/rust/bin/cargo', 'clean', '--manifest-path', '/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/Cargo.toml']
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                149 DEBUG    Command: ['/build/rust/bin/cargo', 'clippy', '--message-format=json', '--manifest-path', '/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/Cargo.toml']
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                149 DEBUG    Command: ['/build/rust/bin/cargo', 'clean', '--manifest-path', '/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/Cargo.toml']
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                 92 DEBUG    Could not parse the output:
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                 93 DEBUG    clippy output: b'    Checking hello_world v0.1.0 (/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1)'
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                 54 DEBUG    Error outside of clippy.This means that the build failed. Therefore, skipping this
[task 2021-04-04T08:49:39.253Z]  0:30.88 __init__.py                 57 DEBUG    File = /builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs / Detail = {'rendered': 'error: aborting due to previous error; 5 warnings emitted\n\n', 'children': [], 'code': None, 'level': 'error', 'message': 'aborting due to previous error; 5 warnings emitted', 'spans': []}
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 54 DEBUG    Error outside of clippy.This means that the build failed. Therefore, skipping this
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 57 DEBUG    File = /builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad.rs / Detail = {'rendered': 'error: aborting due to previous error; 2 warnings emitted\n\n', 'children': [], 'code': None, 'level': 'error', 'message': 'aborting due to previous error; 2 warnings emitted', 'spans': []}
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 92 DEBUG    Could not parse the output:
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 93 DEBUG    clippy output: b'error: could not compile `hello_world`'
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 92 DEBUG    Could not parse the output:
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 93 DEBUG    clippy output: b''
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 92 DEBUG    Could not parse the output:
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 93 DEBUG    clippy output: b'To learn more, run the command again with --verbose.'
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 92 DEBUG    Could not parse the output:
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 93 DEBUG    clippy output: b'warning: build failed, waiting for other jobs to finish...'
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 92 DEBUG    Could not parse the output:
[task 2021-04-04T08:49:39.254Z]  0:30.88 __init__.py                 93 DEBUG    clippy output: b'error: build failed'
[task 2021-04-04T08:49:39.254Z]  0:30.88 _____________________ test_file_and_path_provided[clippy] ______________________```

Comment 1

[Intermittent Failures Robot]

4 failures in 3125 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1702922&startday=2021-03-29&endday=2021-04-04&tree=all

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1702166

Comment 3

[Intermittent Failures Robot]

13 failures in 3854 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 7
• mozilla-central: 6

Platform and build breakdown:

• linux1804-64: 13
  • opt: 13

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1702922&startday=2021-04-05&endday=2021-04-11&tree=all

Comment 4

[Mark Banner (:standard8)]

I've no idea why updating the node_modules would have caused this. These should be separate linters, and clippy shouldn't have anything to do with node_modules.

Maybe Sylvestre or Andrew know.

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Note that this may because there's a new warning being printed:

', source=None, level='warning', rule='unused_mut', lineoffset=0, diff=None, relpath='test1/bad2.rs'), Issue(linter='clippy', path='/builds/worker/checkouts/gecko/tools/lint/test/files/clippy/test1/bad2.rs', lineno=8, column=5, message='calls to `push` immediately after creation', hint='warning: calls to `push` immediately after creation
  --> bad2.rs:8:5
   |
8  | /     let mut vec = Vec::new();
9  | |     vec.push(1);
10 | |     vec.push(2);
   | |________________^ help: consider using the `vec![]` macro: `let mut vec = vec![..];`
   |
   = note: `#[warn(clippy::vec_init_then_push)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push

So, in test_basic, results[6] is no longer the x..10 - 5 warning, but rather the vec.push(...) warning.
Perhaps a clippy upgrade happened on the test machines?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

I guess the docker image has been regenerated because of the eslint update. So, new clippy version, new warning!

The version of clippy seems to match this expectation.

[task 2021-04-04T08:49:39.251Z]  0:30.88 08:49:30.129 clippy (444) | Found version: clippy 0.1.51 (2fd73fa 2021-03-23)

So, we should just fix the warning.

Mark, do you want me to fix this?
thanks

Comment 7

[Mark Banner (:standard8)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #6)

I guess the docker image has been regenerated because of the eslint update. So, new clippy version, new warning!

Could we pin the version of clippy used by the docker images to stop this happening? Having non-obvious things happening is always confusing.

If we can't, could we get the error output to reference documentation on how to check that it was a clippy upgrade and how to fix it?

Mark, do you want me to fix this?

Yes please.

Comment 8

[Andrew Halberstadt [:ahal]]

Sorry was meaning to reply but got a bit busy. Feel free to assign to me Sylvestre and I'll get to it when I have a chance.

Comment 9

[Intermittent Failures Robot]

14 failures in 4255 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9
• mozilla-central: 5

Platform and build breakdown:

• linux1804-64: 14
  • opt: 14

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1702922&startday=2021-04-12&endday=2021-04-18&tree=all

Comment 10

[Intermittent Failures Robot]

17 failures in 3224 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8
• mozilla-beta: 1
• mozilla-central: 8

Platform and build breakdown:

• linux1804-64: 17
  • opt: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1702922&startday=2021-04-19&endday=2021-04-25&tree=all

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1702922 - mozlint/clippy: Set the minimal version of clippy to 2021.03.23 r?#linter-reviewers

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1702922 - mozlint/clippy: Adjust the tests with the new version of clippy r?#linter-reviewers

Depends on D113285

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1702922 - mozlint/ride along: Document how to run a specific testsuite r?#linter-reviewers

Depends on D113286

Comment 14

[Marco Castelluccio [:marco]]

This wasn't caused by bug 1702166 in the end, right?

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Yes and no.
It forced the recreation of the docker image, which updated clippy, which caused this bug :)

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfa04026d5f5
mozlint/ride along: Document how to run a specific testsuite r=linter-reviewers,marco DONTBUILD

Comment 17

[Marco Castelluccio [:marco]]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #15)

Yes and no.
It forced the recreation of the docker image, which updated clippy, which caused this bug :)

Ok, I'll remove it from Regressed By then as it isn't really the cause.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/779e82b3c068
mozlint/clippy: Set the minimal version of clippy to 2021.03.23 r=linter-reviewers,marco DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/cc9234fed3e1
mozlint/clippy: Adjust the tests with the new version of clippy r=linter-reviewers,marco DONTBUILD

Comment 19

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bfa04026d5f5

Comment 20

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/779e82b3c068
https://hg.mozilla.org/mozilla-central/rev/cc9234fed3e1

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Sylvestre, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 22

[Sylvestre Ledru [:Sylvestre]]

not important enough for an uplift :)

Comment 23

[Intermittent Failures Robot]

1 failures in 2908 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform and build breakdown:

• linux1804-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1702922&startday=2021-05-24&endday=2021-05-30&tree=all