1702336 - Disable "signon.management.page.fileImport.enabled" for all channels

Status: VERIFIED FIXED

(Firefox :: about:logins, task, P1)

Description

[Tim Giles [:tgiles]]

Due to the various issues QA has found with the Login CSV import feature, the feature will be turned off until these issues are resolved.

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1702336 - Disable Login CSV import feature for all channels. r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75221f284379
Disable Login CSV import feature for all channels. r=sfoster

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/75221f284379

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this ASAP.

Comment 5

[Tim Giles [:tgiles]]

Comment on attachment 9212934 [details]
Bug 1702336 - Disable Login CSV import feature for all channels. r=sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Login CSV import will stay enabled and could cause Firefox instability when importing a large amount of logins.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch is a pref-flip, should be low risk
• String changes made/needed:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9212934 [details]
Bug 1702336 - Disable Login CSV import feature for all channels. r=sfoster

Approved for 88.0b6.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8941459bcc29

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Nightly 89.0a1 (Build ID: 20210401155139) and Firefox Beta 88.0b6 (Build ID: 20210401185811) on Windows 10 x64, Ubuntu 20.04 and macOS 11.2.3.

• The “signon.management.page.fileImport.enabled” pref is set to “false” value.

However, I have a question: Do we want this feature to be disabled in Nightly as well? I'm asking this because in the past in the Nighty builds the feature was enabled.

Comment 9

[Tim Giles [:tgiles]]

I would say until we resolve Bug 1701660, we should keep this feature disabled in Nightly.