1702837 - Refresh the permissions icons

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Sam Foster [:sfoster] (he/him)]

We have newly drawn icons for representing permissions - as seen in the addressbar/identity box, preferences etc.

• footprints
• footprints blocked
• cryptominer
• cryptominer blocked
• fingerprinter
• fingerprinter blocked
• social-tracker
• social-tracker blocked
• tracking-cookies
• tracking-cookies blocked
• geolocation
• geolocation blocked
• camera
• camera blocked
• microphone
• microphone blocked
• notification
• notification blocked
• screenshare
• screenshare blocked
• storage
• storage blocked
• auto-play-media
• auto-play-media blocked
• canvas
• canvas blocked
• plugin
• plugin blocked
• plugin-20
• xr
• xr blocked
• midi
• blocked-popup*

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I'll see if I can take this.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

It actually looks like a significant number of these icons aren't yet ready. So I'm going to release this bug until more are ready to go.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Actually, in the interests of time, what I'll do is try to split this out into the icons that we currently have available, and get a patch ready for them. The remainder, I'll file a separate bug for.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Okay, here are the icons that we have so far:

• camera
• camera blocked
• screenshare
• screenshare blocked
• storage
• storage blocked
• plugin
• plugin blocked
• xr
• xr blocked
• midi
• blocked-popup

Which means these ones are going to get spun out to a new bug:

• footprints
• footprints blocked
• cryptominers
• cryptominers blocked
• fingerprinters
• fingerprinters disabled
• social-tracker
• social-tracker blocked
• tracking-cookies
• tracking-cookies blocked
• geolocation
• geolocation blocked
• microphone
• microphone blocked
• notification
• notification blocked
• auto-play-media
• auto-play-media blocked
• canvas
• canvas blocked

Not sure what this is:

• plugin-20

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Okay, batch 1 is:

• camera
• camera blocked
• screenshare
• screenshare blocked
• storage
• storage blocked
• plugin
• plugin blocked
• xr
• xr blocked
• midi
• blocked-popup

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1702837 - Update some of our permission icons, batch 1 r?sfoster!

This is Batch 1 of N

Comment 7

[Mike Conley (:mconley) (:⚙️)]

ni'ing self to supply a list of instructions on where testers can see the new icons.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2ab833e2534
Update some of our permission icons, batch 1 r=sfoster

Comment 9

[Atila Butkovits]

https://bugzilla.mozilla.org/show_bug.cgi?id=1686527#c15

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f160141317e9
Update some of our permission icons, batch 1 r=sfoster

Comment 11

[Mike Conley (:mconley) (:⚙️)]

The following sections describe where these icons can generally be found. https://permission.site is a great way to bring some of the permission panels up. https://gist.github.com/mikeconley/304d347b3ec5dfc3552f1311b83efab6 describes ways of getting to the others.

camera.svg

• The URL bar (camera permission)
• Site Permissions panel (when sharing the camera)
• Legacy WebRTC global indicator (when sharing camera on Linux)
• about:preferences (Permissions section)
• Tabs (when sharing camera in background tab)
• The macOS native menu bar (when sharing a camera)

camera-blocked.svg

• The URL bar (camera permission blocked)
• Site Permissions panel (when camera permission blocked)

screen-blocked.svg

• The URL bar when (screenshare permission blocked)
• Site Permissions panel (when screenshare permission blocked)

midi.svg

• URL bar (midi permission) - to spawn this permission, see https://gist.github.com/mikeconley/304d347b3ec5dfc3552f1311b83efab6
• about:preferences (Permissions section).

xr.svg

• URL bar (xr permission) - to spawn this permission, see https://gist.github.com/mikeconley/304d347b3ec5dfc3552f1311b83efab6
• Site Permission panel (xr permission granted)
• about:preferences (Permissions section)

xr-blocked.svg

• URL bar (xr permission blocked) - to spawn this permission, see https://gist.github.com/mikeconley/304d347b3ec5dfc3552f1311b83efab6
• Site Permission panel (xr permission blocked)

persistent-storage-blocked.svg

• URL bar (when persistent storage permission blocked)

screen.svg

• WebRTC global sharing indicator (modern on Windows and macOS, legacy on Linux)
• URL bar (screen permission)
• Site permission panel
• Tabs (when sharing screen in background tab)
• macOS native menu bar

persistent-storage.svg

• URL bar (when permission storage permission granted)

plugin-blocked.svg

• I actually don't think it's possible to see this icon anymore.

plugin.svg

• GMP crash infobar
• about:addons

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f160141317e9

Comment 13

[Oana Botisan, Desktop QA]

Verified the fix using latest Nightly 90.0a1 and Firefox 89.0b10 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.15. All the icons are changed according with the new design.