1705321 - Refresh the remaining permissions icons

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Marco Bonardo [:mak]]

+++ This bug was initially created as a clone of Bug #1702837 +++

The original bug replaced some of the icons, but many still have to be replaced.
browser/themes/shared/identity-block/permissions.svg
And various icons in browser/themes/shared/notification-icons also look old style.

Comment 1

[Marco Bonardo [:mak]]

I had set a needinfo but it got lost somehow.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Thanks for filing, yes there are some still to do. We have a https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE which provides links to where to find the new icon assets, suggested procedure and tracking spreadsheet for icon updates - it maps the paths of icons in m-c to the new icons where a change is planned. Not every icon was in scope - that's indicated in the spreadsheet as "No change planned".

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Here's the list of icons that this bug will focus on updating:

• browser/themes/windows/notification-icons/geo.svg (location.svg)
• browser/themes/windows/notification-icons/geo-blocked.svg (location-blocked.svg)
• browser/themes/linux/notification-icons/geo.svg (location.svg)
• browser/themes/linux/notification-icons/geo-blocked.svg (location-blocked.svg)
• browser/themes/shared/identity-block/permissions.svg (permission.svg)
• browser/themes/shared/notification-icons/popup-subitem.svg (popup-subitem.svg)
• browser/themes/shared/notification-icons/autoplay-media-detailed.svg (auto-play-media.svg)
• browser/themes/shared/notification-icons/autoplay-media-blocked.svg (auto-play-media-blocked.svg)
• browser/themes/shared/notification-icons/desktop-notification.svg (notification.svg)
• browser/themes/shared/notification-icons/canvas-blocked.svg (canvas-blocked.svg)
• browser/themes/shared/notification-icons/popup.svg (blocked-popup.svg)
• browser/themes/shared/notification-icons/block-cryptominer.svg (cryptominer-blocked.svg)
• browser/themes/shared/notification-icons/block-cryptominer-dark.svg (cryptominer.svg)
• browser/themes/shared/notification-icons/webauthn.svg (fingerprinter.svg)
• browser/themes/shared/notification-icons/autoplay-media.svg (auto-play-media.svg)
• browser/themes/shared/notification-icons/canvas.svg (canvas.svg)
• browser/themes/shared/notification-icons/block-fingerprinter.svg (fingerprinter-blocked.svg)
• browser/themes/shared/notification-icons/desktop-notification-blocked.svg (notification-blocked.svg)
• browser/themes/shared/notification-icons/block-fingerprinter-dark.svg (fingerprinter-blocked.svg)
• browser/themes/shared/notification-icons/block-social.svg (social-tracker-blocked.svg)
• browser/themes/shared/notification-icons/indexedDB.svg (storage.svg)
• browser/themes/shared/notification-icons/focus-tab-by-prompt.svg (warning-fill-20.svg)
• browser/themes/osx/notification-icons/geo.svg (location.svg)
• browser/themes/osx/notification-icons/geo-blocked.svg (location-blocked.svg)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1705321 - Update some of our permission icons, batch 2 r?sfoster!,Mardak!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9292746fe215
Update some of our permission icons, batch 2 r=sfoster,Mardak

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9292746fe215

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9216948 [details]
Bug 1705321 - Update some of our permission icons, batch 2 r?sfoster!,Mardak!

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is mainly an asset swap with a new set of icons for various permission things.
• String changes made/needed: None.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9216948 [details]
Bug 1705321 - Update some of our permission icons, batch 2 r?sfoster!,Mardak!

Approved for 89 Beta 3, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3dba72213a67

Comment 10

[Mike Conley (:mconley) (:⚙️)]

ni'ing myself to include a list of places where these icons exist for QA to test.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Here's a list of places where the new icons from this bug can be seen:

browser/themes/windows/notification-icons/geo.svg (location.svg), browser/themes/linux/notification-icons/geo.svg (location.svg), browser/themes/osx/notification-icons/geo.svg (location.svg)

• The URL bar (when sharing location, or a site is requesting location permission)
• The Site Permission panel (when location is shared)
• The about:preferences Permissions list

browser/themes/windows/notification-icons/geo-blocked.svg (location-blocked.svg), browser/themes/linux/notification-icons/geo-blocked.svg (location-blocked.svg), browser/themes/osx/notification-icons/geo-blocked.svg (location-blocked.svg)

• The URL bar (when location sharing is blocked)
• The Site Permission panel (when location sharing is blocked)

browser/themes/shared/identity-block/permissions.svg (permission.svg)

• The URL bar (when the Site Permissions panel can be opened)

browser/themes/shared/notification-icons/popup-subitem.svg (popup-subitem.svg)

• The Site Permission panel after sharing Location, but only with Proton disabled. With Proton enabled, this icon is not used.

browser/themes/shared/notification-icons/autoplay-media-detailed.svg (auto-play-media.svg)

• about:preferences in the Permissions list

browser/themes/shared/notification-icons/autoplay-media-blocked.svg (auto-play-media-blocked.svg)

• The URL bar (when the user has blocked autoplay permissions for a site)
• The Site Permission panel (when the user has blocked autoplay permissions for a site)

browser/themes/shared/notification-icons/desktop-notification.svg (notification.svg)

• The URL bar (when the DOM notification permission has been requested by a site)
• The Site Permission panel (when the DOM notification permission has been granted)
• about:preferences (in the Permissions list)

browser/themes/shared/notification-icons/canvas-blocked.svg (canvas-blocked.svg)

• The URL bar (when privacy.resistFingerprinting is enabled, and the canvas permission is blocked)
• The Site Permission panel (when privacy.resistFingerprinting is enabled, and the canvas permission is blocked)

browser/themes/shared/notification-icons/popup.svg (blocked-popup.svg)

• The Popup Blocker infobar
• The URL bar (after a popup is blocked)
• The Site Permission panel (after a popup is blocked)

browser/themes/shared/notification-icons/block-cryptominer.svg (cryptominer-blocked.svg)

• Used by a now-defunct CFR message... nothing to do here.

browser/themes/shared/notification-icons/block-cryptominer-dark.svg (cryptominer.svg)

• Used by a now-defunct CFR message... nothing to do here.

browser/themes/shared/notification-icons/webauthn.svg (fingerprinter.svg)

• The URL bar (when showing WebAuthn panel)

browser/themes/shared/notification-icons/autoplay-media.svg (auto-play-media.svg)

• The Site Permission panel (when the user has allowed autoplay permissions for a site)

browser/themes/shared/notification-icons/canvas.svg (canvas.svg)

• The URL bar (when privacy.resistFingerprinting is enabled, and the canvas permission is requested)
• The Site Permission panel (when privacy.resistFingerprinting is enabled, and the canvas permission is granted)

browser/themes/shared/notification-icons/block-fingerprinter.svg (fingerprinter-blocked.svg)

• Used by a now-defunct CFR message... nothing to do here.

browser/themes/shared/notification-icons/desktop-notification-blocked.svg (notification-blocked.svg)

• The URL bar (when a DOM notification is blocked)
• The Site Permission panel (when DOM notifications are blocked)

browser/themes/shared/notification-icons/block-fingerprinter-dark.svg (fingerprinter-blocked.svg)

• Used by a now-defunct CFR message... nothing to do here.

browser/themes/shared/notification-icons/block-social.svg (social-tracker-blocked.svg)

• Used by a now-defunct CFR message... nothing to do here.

browser/themes/shared/notification-icons/indexedDB.svg (storage.svg)

• The URL bar (when IndexedDB persistent storage permission is requested)

browser/themes/shared/notification-icons/focus-tab-by-prompt.svg (warning-fill-20.svg)

• The Site Permission panel when a site is allowed to have their modals switch the user's selected tab when they open

Comment 12

[Rares Doghi, Desktop QA]

Some of These icons have been removed by Bug 1714351 and Bug 1707101 but I was able to verify the remaining ones and I can confirm that this issue is Verified as Fixed. Thank you Mike for the list and where to find each of them.

This issue is verified as fixed in 89.0.2, Beta 90.0b12 and our latest Nightly build 91.0a1 (2021-07-07), on Mac 11.0, Windows 10 and Ubuntu 20.