Recipient email address saved in message draft disappears when re-opening/editing draft [add-on API issue]
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(Not tracked)
People
(Reporter: halle_saale, Unassigned)
References
Details
(Whiteboard: [affects add-ons only])
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:87.0) Gecko/20100101 Firefox/87.0
Steps to reproduce:
I entered the email address, then a subject. Then I saved the mail.
If I then want to edit it, the email address line is empty.
Actual results:
email address is not saved
Expected results:
The complete mail should be saved, including the email address.
|
||
Comment 1•4 years ago
|
||
I'm not seeing this on beta.
Does it happen after doing Help > restart with add-ons disabled?
|
||
Comment 2•4 years ago
|
||
Same here. Testing with 88.0 b2. Used some made up email address and generic subject line, CTRL-S to save as Draft, went to Drafts folder and re-opened message and the made up email address and generic subject was still intact.
|
Reporter | |
Comment 3•4 years ago
|
||
The only add-on I have installed is "Signature Switch". If this is disables, then the email address is also saved.
Okay, then this is reason, But why?
|
|
||
Comment 4•4 years ago
|
||
(In reply to halle_saale from comment #3)
The only add-on I have installed is "Signature Switch". If this is disables, then the email address is also saved.
Okay, then this is reason, But why?
Hard to say without code inspection but maybe reaching out to the Extension author and letting them know about it might be a good place to start. Point the author to this bug report as well.
This might yield some info:
Start TB normaslly and then...
- Do a CTRL-SHIFT-J to open Error Console
- Click the garbage can up at top left to clear the screen
- With Error Console still open, switch back to TB
- Try to reproduce your steps that causes the bug
I would think that once you save as Draft, the issue will be present so switch back to the Error Console and see if any error is there that might refer to the email address not being saved.
|
||
Comment 6•4 years ago
|
||
(In reply to halle_saale from comment #3)
The only add-on I have installed is "Signature Switch". If this is disables, then the email address is also saved.
Okay, then this is reason, But why?
So per reporter's comment 3, this is caused by SignatureSwitch add-on (so it's invalid as a Thunderbird bug, falls into addon author's responsiblity).
Iiuc, STR are: compose, enter recipient, save as draft, close, re-open draft -> recipient gone.
We have seen somewhat similar problems with SignatureSwitch add-on in Bug 1696765.
Achim (addon-author), could you comment?
|
|
||
Updated•4 years ago
|
|
||
Comment 7•4 years ago
|
||
(In reply to Thomas D. (:thomas8) from comment #6)
We have seen somewhat similar problems with SignatureSwitch add-on in Bug 1696765.
Achim (addon-author), could you comment?
Sure.
As John already stated:
Yes, requested by add-on developers getComposeDetails should contain partially entered values, which needed an enforced pillification. Hm. Achim is not doing something illegal. How do we solve this? Lets move this discussion over to bug 1681008.
The add-on is using pure WebExtension/MailExtension APIs... no experiments or other "hacky code" (imho).
The sourcecode can be found here:
https://github.com/4ch1m/mozext/tree/master/signatureswitch-me
I haven't yet found the time to investigate which parts of the base code are broken or lead to the described behaviour.
|
|
||
Comment 8•4 years ago
•
|
||
.
|
|
||
Comment 9•4 years ago
|
||
Sorry for the noise, but I'm going to reshuffle this a bit.
Hadn't seen that duplicate bug 1702957 was filed by Achim himself (addon-author of SignatureSwitch).
So let's sort it out there.
|
||
Comment 10•4 years ago
|
||
I have posted a quick fix for the add-on here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1702957#c6
But it is a bug in the API, Achim did nothing wrong. Working on a fix in the other bug.
|
|
||
Comment 11•4 years ago
|
||
(In reply to John Bieling (:TbSync) from comment #10)
I have posted a quick fix for the add-on here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1702957#c6But it is a bug in the API, Achim did nothing wrong. Working on a fix in the other bug.
Ah alright, now I get it! Let's correct the summary then.
Description
•