Open Bug 1702905 Opened 1 month ago Updated 4 days ago

Tidy and enhance subscribe UI code in SeaMonkey 2.53 and 2.57

Categories

(SeaMonkey :: MailNews: Account Configuration, enhancement)

enhancement

Tracking

(seamonkey2.53? affected, seamonkey2.57esr? affected)

ASSIGNED
Tracking Status
seamonkey2.53 ? affected
seamonkey2.57esr ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Whiteboard: SM2.53.8)

Attachments

(1 file, 2 obsolete files)

At the moment the subscribe UI code suffers from:

  • Lots of code duplication.
  • Some function callers using incorrect number of arguments (fall out from Bug 1466705).
  • Subscribe indicators not always being repainted when their state changes.
  • Some code not picking up when switching back from search mode.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: UI issues in the subscribe dialog
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9213483 - Flags: review?(frgrahl)
Attachment #9213483 - Flags: approval-comm-release?
Attachment #9213483 - Flags: approval-comm-esr60?
Blocks: 1688496

Correctly refreshed version.

Attachment #9213483 - Attachment is obsolete: true
Attachment #9213483 - Flags: review?(frgrahl)
Attachment #9213483 - Flags: approval-comm-release?
Attachment #9213483 - Flags: approval-comm-esr60?
Attachment #9213484 - Flags: review?(frgrahl)
Attachment #9213484 - Flags: approval-comm-release?
Attachment #9213484 - Flags: approval-comm-esr60?

Comment on attachment 9213484 [details] [diff] [review]
1702905-subscribe-tidy-2538.patch

LGTM r/a+

NITS:
As discussed on irc has some multi declarations in one statement which should be split for readability e.g.

  • let start = {}, end = {};
Attachment #9213484 - Flags: review?(frgrahl)
Attachment #9213484 - Flags: review+
Attachment #9213484 - Flags: approval-comm-release?
Attachment #9213484 - Flags: approval-comm-release+
Attachment #9213484 - Flags: approval-comm-esr60?
Attachment #9213484 - Flags: approval-comm-esr60+

Review comment addressed, carrying forward r/a

Attachment #9213484 - Attachment is obsolete: true
Attachment #9220183 - Flags: review+
Attachment #9220183 - Flags: approval-comm-release+
Attachment #9220183 - Flags: approval-comm-esr60+
Summary: Tidy and enhance subscribe UI code → Tidy and enhance subscribe UI code in SeaMonkey 2.53 and 2.57
Whiteboard: SM2.53.8
You need to log in before you can comment on or make changes to this bug.