1702958 - Informational infobars have the wrong (i) icon on Proton

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Peter_M]

Attachment: Actual vs Expected.png

Affected versions
Firefox Nightly 89.0a1

Preconditions
browser.proton.enabled= true
browser.proton.infobars.enabled= true

Steps to reproduce

1. Launch Firefox Nightly
2. Navigate to https://permission.site
3. Click on "Protocol Handler"

Expected Results
The Protocol handler informational infobar appears properly and has the correct (!) icon

Actual Results
The informational infobar's icon is not the correct one

Comment 1

[Tyler Duzan]

Current icon colors also appear to be incorrect, but I think were going to be fixed when new icon assets were provided. Like most of the icon issues, this should be a P1 for this component.

Comment 2

[Sam Foster [:sfoster] (he/him)]

We have a https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE which provides links to where to find the new icon assets, suggested procedure and tracking spreadsheet for icon updates.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1702958 - Update info icon in infobars. r?mstriemer!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e93aab35f3ea
Update info icon in infobars. r=mstriemer

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset e93aab35f3ea (bug 1702958) for causing mochitest failures in test_notificationbox.xhtml.
https://hg.mozilla.org/integration/autoland/rev/a4a567751ed3ebc444a06d1cefcd97c0e9099808

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=e93aab35f3ea1efd5bbbaef3f5824dcd9e6472c7&selectedTaskRun=RBcu0MaJQrqoPR5Q2ysyGw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=336386900&repo=autoland&lineNumber=2631

Comment 6

[Alexandru Michis [:malexandru]]

Update: has also caused bc failures in browser_registerProtocolHandler_notification.js on all platforms.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c83038fb6684
Update info icon in infobars. r=mstriemer

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c83038fb6684

Comment 9

[Peter_M]

Verified the fix on MacOS 11, Windows 10 and Ubuntu 20.04 using Firefox Nightly 89.0a1 (20210414093129).
Both dark and light theme versions of the icon correspond to the specifications.