Closed Bug 1702958 Opened 8 months ago Closed 8 months ago

Informational infobars have the wrong (i) icon on Proton

Categories

(Firefox :: Theme, defect, P1)

Unspecified
All
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: peter.magyari, Assigned: mconley)

References

(Blocks 3 open bugs, )

Details

(Whiteboard: [proton-infobars])

Attachments

(2 files)

Attached image Actual vs Expected.png

Affected versions
Firefox Nightly 89.0a1

Preconditions
browser.proton.enabled= true
browser.proton.infobars.enabled= true

Steps to reproduce

  1. Launch Firefox Nightly
  2. Navigate to https://permission.site
  3. Click on "Protocol Handler"

Expected Results
The Protocol handler informational infobar appears properly and has the correct (!) icon

Actual Results
The informational infobar's icon is not the correct one

Current icon colors also appear to be incorrect, but I think were going to be fixed when new icon assets were provided. Like most of the icon issues, this should be a P1 for this component.

Priority: -- → P1
Blocks: 1702330

We have a https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE which provides links to where to find the new icon assets, suggested procedure and tracking spreadsheet for icon updates.

Assignee: nobody → mconley
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e93aab35f3ea
Update info icon in infobars. r=mstriemer

Update: has also caused bc failures in browser_registerProtocolHandler_notification.js on all platforms.

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c83038fb6684
Update info icon in infobars. r=mstriemer
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified the fix on MacOS 11, Windows 10 and Ubuntu 20.04 using Firefox Nightly 89.0a1 (20210414093129).
Both dark and light theme versions of the icon correspond to the specifications.

Status: RESOLVED → VERIFIED
Flags: needinfo?(mconley)
You need to log in before you can comment on or make changes to this bug.