Informational infobars have the wrong (i) icon on Proton
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox87 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | verified |
People
(Reporter: pmagyari, Assigned: mconley)
References
(Blocks 3 open bugs, )
Details
(Whiteboard: [proton-infobars])
Attachments
(2 files)
Affected versions
Firefox Nightly 89.0a1
Preconditions
browser.proton.enabled= true
browser.proton.infobars.enabled= true
Steps to reproduce
- Launch Firefox Nightly
- Navigate to https://permission.site
- Click on "Protocol Handler"
Expected Results
The Protocol handler informational infobar appears properly and has the correct (!) icon
Actual Results
The informational infobar's icon is not the correct one
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Current icon colors also appear to be incorrect, but I think were going to be fixed when new icon assets were provided. Like most of the icon issues, this should be a P1 for this component.
Comment 2•3 years ago
|
||
We have a https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE which provides links to where to find the new icon assets, suggested procedure and tracking spreadsheet for icon updates.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e93aab35f3ea Update info icon in infobars. r=mstriemer
Comment 5•3 years ago
|
||
Backed out changeset e93aab35f3ea (bug 1702958) for causing mochitest failures in test_notificationbox.xhtml.
https://hg.mozilla.org/integration/autoland/rev/a4a567751ed3ebc444a06d1cefcd97c0e9099808
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=e93aab35f3ea1efd5bbbaef3f5824dcd9e6472c7&selectedTaskRun=RBcu0MaJQrqoPR5Q2ysyGw.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=336386900&repo=autoland&lineNumber=2631
Comment 6•3 years ago
|
||
Update: has also caused bc failures in browser_registerProtocolHandler_notification.js on all platforms.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c83038fb6684 Update info icon in infobars. r=mstriemer
![]() |
||
Comment 8•3 years ago
|
||
bugherder |
Reporter | ||
Comment 9•3 years ago
|
||
Verified the fix on MacOS 11, Windows 10 and Ubuntu 20.04 using Firefox Nightly 89.0a1 (20210414093129).
Both dark and light theme versions of the icon correspond to the specifications.
Assignee | ||
Updated•3 years ago
|
Description
•