1702330 - Graduate the infobars to the main proton pref

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mark Striemer [:mstriemer]]

Once the UX issues are resolved and the tests are green we can graduate to the browser.proton.enabled pref.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Graduate infobars to main proton pref r?jaws

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Remove -moz-proton-infobars media query support r?emilio

Depends on D110638

Comment 3

[Tyler Duzan]

Note, I added two P1s as blockers on this, however we had discussed today in the call we will go ahead and graduate sub-components in Nightly to gather wider feedback even if all blocking issues are not resolved and continue to work on resolution.l

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Fix browser_registerProtocolHandler_notification.js r?jaws

Depends on D110963

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Use local gProton in notificationbox.js r?jaws

Depends on D111308

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Remove lazy notification deck creation test r?jaws

This test no longer passes with proton enabled by default, since the
deck would've been created already during startup.

Depends on D111309

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb2a8569ed02
Graduate infobars to main proton pref r=jaws,marionette-reviewers
https://hg.mozilla.org/integration/autoland/rev/907e4fcda266
Remove -moz-proton-infobars media query support r=emilio
https://hg.mozilla.org/integration/autoland/rev/e1277c21543f
Fix browser_registerProtocolHandler_notification.js r=mconley
https://hg.mozilla.org/integration/autoland/rev/eba73c72be18
Use local gProton in notificationbox.js r=mconley
https://hg.mozilla.org/integration/autoland/rev/365fd1bb6dde
Remove lazy notification deck creation test r=mconley

Comment 8

[Alexandru Michis [:malexandru]]

Backed out 5 changesets (Bug 1702330) for causing failures in browser_aboutNewTab_defaultBrowserNotification.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/bcc83b8283c73e59977bf4186af276a62f75a973
Push with failures, failure log.
(Update): Also causes bc failures in browser_ext_slow_script.js.

Comment 9

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Fix browser_aboutNewTab_defaultBrowserNotification.js proton infobars r?mconley

Depends on D111310

Comment 10

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Fix browser_ext_slow_script.js proton infobars r?mconley

Depends on D111356

Comment 11

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Skip browser_registerProtocolHandler_notification.js verify r?mconley

Depends on D111357

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e72fb8b52609
Graduate infobars to main proton pref r=jaws,marionette-reviewers
https://hg.mozilla.org/integration/autoland/rev/65faaeeb2339
Remove -moz-proton-infobars media query support r=emilio
https://hg.mozilla.org/integration/autoland/rev/1e5ccb47056e
Fix browser_registerProtocolHandler_notification.js r=mconley
https://hg.mozilla.org/integration/autoland/rev/b9964fb4dd70
Use local gProton in notificationbox.js r=mconley
https://hg.mozilla.org/integration/autoland/rev/63cec3eadb4f
Remove lazy notification deck creation test r=mconley
https://hg.mozilla.org/integration/autoland/rev/809af1f94b4b
Fix browser_aboutNewTab_defaultBrowserNotification.js proton infobars r=mconley
https://hg.mozilla.org/integration/autoland/rev/15f60f1d3f14
Fix browser_ext_slow_script.js proton infobars r=mconley
https://hg.mozilla.org/integration/autoland/rev/b81511f8e157
Skip browser_registerProtocolHandler_notification.js verify r=mconley

Comment 13

[Dorel Luca [:dluca]]

Backed out 8 changesets (bug 1702330)for Browser-chrome failures in est/popups/browser_popup_blocker.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=335993732&repo=autoland&lineNumber=2837

https://treeherder.mozilla.org/logviewer?job_id=335995853&repo=autoland&lineNumber=123819

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=b81511f8e1579c2aafd552cd82551705127ff5e2

Backout:
https://hg.mozilla.org/integration/autoland/rev/daf3a38bbb77c5563c4076d05acd59e79ab8c856

Comment 14

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Fix browser_popup_blocker.js proton infobars r?jaws

Depends on D111358

Comment 15

[Mark Striemer [:mstriemer]]

Attachment: Bug 1702330 - Disable verify on browser_aboutNewTab_defaultBrowserNotification.js r?jaws

Depends on D111473

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7f0de372b21
Graduate infobars to main proton pref r=jaws,marionette-reviewers
https://hg.mozilla.org/integration/autoland/rev/4b345ea924cc
Fix browser_registerProtocolHandler_notification.js r=mconley
https://hg.mozilla.org/integration/autoland/rev/607be325b4e8
Use local gProton in notificationbox.js r=mconley
https://hg.mozilla.org/integration/autoland/rev/4bb6ceb6adb3
Remove lazy notification deck creation test r=mconley
https://hg.mozilla.org/integration/autoland/rev/3b75ffae171a
Fix browser_aboutNewTab_defaultBrowserNotification.js proton infobars r=mconley
https://hg.mozilla.org/integration/autoland/rev/d76516e0d07d
Fix browser_ext_slow_script.js proton infobars r=mconley
https://hg.mozilla.org/integration/autoland/rev/5425a2312f6e
Skip browser_registerProtocolHandler_notification.js verify r=mconley
https://hg.mozilla.org/integration/autoland/rev/79c63bf11b29
Fix browser_popup_blocker.js proton infobars r=jaws
https://hg.mozilla.org/integration/autoland/rev/f84605e6fc8b
Disable verify on browser_aboutNewTab_defaultBrowserNotification.js r=jaws

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c7f0de372b21
https://hg.mozilla.org/mozilla-central/rev/4b345ea924cc
https://hg.mozilla.org/mozilla-central/rev/607be325b4e8
https://hg.mozilla.org/mozilla-central/rev/4bb6ceb6adb3
https://hg.mozilla.org/mozilla-central/rev/3b75ffae171a
https://hg.mozilla.org/mozilla-central/rev/d76516e0d07d
https://hg.mozilla.org/mozilla-central/rev/5425a2312f6e
https://hg.mozilla.org/mozilla-central/rev/79c63bf11b29
https://hg.mozilla.org/mozilla-central/rev/f84605e6fc8b

Comment 18

[Dorel Luca [:dluca]]

Backed out 9 changesets (bug 1702330) for Mochitest failures in toolkit/components/url-classifier/tests/mochitest/test_reporturl.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=336052353&repo=autoland&lineNumber=118382

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=f84605e6fc8b40f6631ea4cb3628d98608ab1b0c

Backout:
https://hg.mozilla.org/integration/autoland/rev/05337140272cc5fe59e58b9d302fb84eda9acbf3

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/05337140272c

Comment 20

[Ed Lee :Mardak]

Attachment: Bug 1702330 - Fix test_reporturl.html proton infobars r?mstriemer,mconley,jaws

Depends on D110963

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7ccaffc49b8
Graduate infobars to main proton pref r=jaws,marionette-reviewers
https://hg.mozilla.org/integration/autoland/rev/df997a403efd
Fix browser_registerProtocolHandler_notification.js r=mconley
https://hg.mozilla.org/integration/autoland/rev/cba0c03c083e
Use local gProton in notificationbox.js r=mconley
https://hg.mozilla.org/integration/autoland/rev/ec5d081aeb16
Remove lazy notification deck creation test r=mconley
https://hg.mozilla.org/integration/autoland/rev/15535a25969f
Fix browser_aboutNewTab_defaultBrowserNotification.js proton infobars r=mconley
https://hg.mozilla.org/integration/autoland/rev/20d8471f9074
Fix browser_ext_slow_script.js proton infobars r=mconley
https://hg.mozilla.org/integration/autoland/rev/a046fda26825
Skip browser_registerProtocolHandler_notification.js verify r=mconley
https://hg.mozilla.org/integration/autoland/rev/0ecae586c2c7
Fix browser_popup_blocker.js proton infobars r=jaws
https://hg.mozilla.org/integration/autoland/rev/f3642f0a1cfd
Disable verify on browser_aboutNewTab_defaultBrowserNotification.js r=jaws
https://hg.mozilla.org/integration/autoland/rev/0ea49daf534f
Fix test_reporturl.html proton infobars r=mstriemer

Comment 22

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f7ccaffc49b8
https://hg.mozilla.org/mozilla-central/rev/df997a403efd
https://hg.mozilla.org/mozilla-central/rev/cba0c03c083e
https://hg.mozilla.org/mozilla-central/rev/ec5d081aeb16
https://hg.mozilla.org/mozilla-central/rev/15535a25969f
https://hg.mozilla.org/mozilla-central/rev/20d8471f9074
https://hg.mozilla.org/mozilla-central/rev/a046fda26825
https://hg.mozilla.org/mozilla-central/rev/0ecae586c2c7
https://hg.mozilla.org/mozilla-central/rev/f3642f0a1cfd
https://hg.mozilla.org/mozilla-central/rev/0ea49daf534f

Comment 23

[Sören Hentzschel]

This ticket is closed but there are still a few references to browser.proton.infobars.enabled. Is this expected?

https://searchfox.org/mozilla-central/rev/a1c854d385d8fd40b981e694b4a9a725d86e5ab5/modules/libpref/init/StaticPrefList.yaml#1168
https://searchfox.org/mozilla-central/rev/a1c854d385d8fd40b981e694b4a9a725d86e5ab5/servo/components/style/gecko/media_features.rs#866
https://searchfox.org/mozilla-central/rev/a1c854d385d8fd40b981e694b4a9a725d86e5ab5/widget/nsXPLookAndFeel.cpp#424

Comment 24

[Ed Lee :Mardak]

Looks like https://phabricator.services.mozilla.com/D110963 was moved to the end of the stack and didn't land with the rest?

Probably because the patch conflicted with Bug 1703274 already decrementing the array length:

-pub static MEDIA_FEATURES: [MediaFeatureDescription; 63] = [
+pub static MEDIA_FEATURES: [MediaFeatureDescription; 62] = [

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d03336aafcf
Remove -moz-proton-infobars media query support r=emilio

Comment 26

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1d03336aafcf

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3ed00a2283d
Port bug 1702330 - Graduate the infobars to the main proton pref. rs=bustage-fix DONTBUILD

Comment 28

[Intermittent Failures Robot]

1 failures in 3854 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• linux1804-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1702330&startday=2021-04-05&endday=2021-04-11&tree=all

Comment 29

[Simona Badau, Desktop QA]

Verified as fixed using the latest Firefox 89 beta 2 and the latest Nightly 90.0a1 - the Infobars feature is now graduated to the main proton pref "browser.proton.enabled". Verified on macOS BigSur 11.2, Ubuntu 20.04 x64, and Windows 10 x64.