Bookmark Button on Toolbar - Proton Bookmark submenu shadow doesn't match main menu shadow
Categories
(Firefox :: Toolbars and Customization, defect, P2)
Tracking
()
People
(Reporter: acid.crash.lv, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-door-hangers][priority:2c])
Attachments
(3 files)
bookmarkPopup.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0
Steps to reproduce:
EnableProtonUI
browser.proton.enabled
browser.proton.contextmenus.enabled
browser.proton.doorhangers.enabled
Place "Show Your Bookmarks" button to Navbar
Click on In
Observe styling of PopUp
Actual results:
Bookmark PopUp suffers from offset Shadows.
Expected results:
Bookmark PopUp should be have correct visual design
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
The issue with the shadow styling is fixed now with 89.0a1 (2021-04-09) (64-bit)
However, there is also an issue with shadow styles for the subfolders within bookmarks
The style doesn't match with the root folder
|
||
Updated•5 years ago
|
Confirming this issue on Windows 10 x64 and setting up proper flags.
Hi here.
It has been two mounts since this issue was filed.
The Proton is now active within Release and the issue is still there.
Bookmark menu subfolders do not have proper border-radius and shadow.
Do you plan on fixing this?
|
|
||
Comment 6•5 years ago
|
||
(In reply to Serge from comment #4)
It has been two mounts since this issue was filed.
Age is not a factor in when we address bugs. Older bugs are not necessarily more important bugs - if we break something tomorrow that crashes Firefox for 10% of users, that is obviously more important than a 2-year old issue that only affects 5 people, to give an extreme example.
This bug was prioritized as P2c, which means P1 and P2a and P2b bugs will likely be prioritized over it.
Bookmark menu subfolders do not have proper border-radius and shadow.
Do you plan on fixing this?
I hope we will, but I don't have a timeline for you. There is some work happening in bug 1703051 which I suspect will improve things a bit. That bug has been actively worked on for a while now, but both this issue and that one are technically difficult to fix because the implementation of the bookmarks menu button and bookmarks toolbar folders (the main focus of that bug) is very different from that of the hamburger menu, and so making them look the same is not trivial.
Description
•