Closed Bug 1702990 Opened 4 years ago Closed 4 years ago

Separators from Proton spec missing in the Bookmarks Panel

Categories

(Firefox :: Bookmarks & History, task, P2)

Product:
Firefox
Component:
Bookmarks & History
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mconley, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers][priority:2b] [proton-uplift])

Attachments

(1 file)

Bug 1702990, add toolbarseparator to bookmark panel
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

The specification called for separators immediately above and below the preview screenshot of the bookmarked page in the panel.

Those separators should have 16px of margin on the left and right sides from the edges of the panel. There should be ~4px of space between the separators and the screenshot. There should be ~12px of space between the bottom separator and the "Name" form input label.

Depends on: 1702995
Priority: -- → P2
Whiteboard: [proton-door-hangers] → [proton-door-hangers][priority:2b]
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Attachment #9217454 - Attachment description: Bug 1702990, add toolbarseparator to bookmarks toolbar → Bug 1702990, add toolbarseparator to bookmark panel
No longer depends on: 1702995
See Also: → 1702995
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/071d91360e5b add toolbarseparator to bookmark panel r=mconley

https://hg.mozilla.org/mozilla-central/rev/071d91360e5b

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9217454 [details]
Bug 1702990, add toolbarseparator to bookmark panel

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No string changes
  • String changes made/needed: n/a
Attachment #9217454 - Flags: approval-mozilla-beta?

Comment on attachment 9217454 [details]
Bug 1702990, add toolbarseparator to bookmark panel

Approved for 89 beta 5, thanks.

Attachment #9217454 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox89: --- → affected
Whiteboard: [proton-door-hangers][priority:2b] → [proton-door-hangers][priority:2b] [proton-uplift]

I've verified this issue on latest Nightly 90.0a1 and Beta 89.0b6, but it seems that the separator is displayed only below the preview screenshot. Please see the this image taken from macOS 10.15.

Hi Emma, could you please take a look at this, please?

Flags: needinfo?(emalysz)

Thanks Ciprian! I had missed that part and only added one separator. I just filed Bug 1708481 to take care of the header separator.

Flags: needinfo?(emalysz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: