Closed
Bug 1708481
Opened 4 years ago
Closed 4 years ago
Header separator from Proton spec missing in the Bookmarks Panel
Categories
(Firefox :: Bookmarks & History, task, P2)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
90 Branch
People
(Reporter: emmamalysz, Assigned: emmamalysz)
References
(Blocks 1 open bug)
Details
(Keywords: helpwanted, Whiteboard: [proton-door-hangers][priority:2b] [proton-uplift])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1702990 +++
I had missed that we also wanted to add the separator directly below the edit bookmark heading as well. I'm copying over the priority level from the previous bug
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1549
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bb236e351f1
add separator beneath bookmarks panel header r=mconley
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Comment 4•4 years ago
|
||
Comment on attachment 9219256 [details]
Bug 1708481, add separator beneath bookmarks panel header
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): A pretty small, CSS-only change that only impacts the bookmarks panel.
- String changes made/needed: None.
Attachment #9219256 -
Flags: approval-mozilla-beta?
Updated•4 years ago
|
status-firefox89:
--- → affected
Whiteboard: [proton-door-hangers][priority:2b] → [proton-door-hangers][priority:2b] [proton-uplift]
Comment 5•4 years ago
|
||
Comment on attachment 9219256 [details]
Bug 1708481, add separator beneath bookmarks panel header
Approved for 89 beta 7, thanks.
Attachment #9219256 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•4 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•