Closed Bug 1708481 Opened 3 years ago Closed 3 years ago

Header separator from Proton spec missing in the Bookmarks Panel

Categories

(Firefox :: Bookmarks & History, task, P2)

Product:
Firefox
Component:
Bookmarks & History
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: emmamalysz, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers][priority:2b] [proton-uplift])

Attachments

(1 file)

Bug 1708481, add separator beneath bookmarks panel header
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

+++ This bug was initially created as a clone of Bug #1702990 +++

I had missed that we also wanted to add the separator directly below the edit bookmark heading as well. I'm copying over the priority level from the previous bug

Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0bb236e351f1
add separator beneath bookmarks panel header r=mconley

https://hg.mozilla.org/mozilla-central/rev/0bb236e351f1

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9219256 [details]
Bug 1708481, add separator beneath bookmarks panel header

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): A pretty small, CSS-only change that only impacts the bookmarks panel.
  • String changes made/needed: None.
Attachment #9219256 - Flags: approval-mozilla-beta?
status-firefox89: --- → affected
Whiteboard: [proton-door-hangers][priority:2b] → [proton-door-hangers][priority:2b] [proton-uplift]

Comment on attachment 9219256 [details]
Bug 1708481, add separator beneath bookmarks panel header

Approved for 89 beta 7, thanks.

Attachment #9219256 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: