1703089 - Implement the final JS API for Wasm exceptions

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Asumu Takikawa]

Currently the Wasm exception handling implemention in Spidermonkey has a skeleton of a JS API based on what seems to be the current consensus, but the spec API is not fully fleshed out yet.

On the specification side, I started a discussion on finalizing the API: https://github.com/WebAssembly/exception-handling/issues/150

I'll attach some WIP patches here that prototype a possible direction for that API. I'll evolve these patches as the API becomes more solid.

Comment 1

[Asumu Takikawa]

Attachment: Bug 1703089 - Implement WebAssembly.Exception constructor

Comment 2

[Asumu Takikawa]

Attachment: Bug 1703089 - Add WebAssembly.Exception methods

Depends on D110851

Comment 3

[Asumu Takikawa]

Attachment: Bug 1703089 - Implement WebAssembly.Tag constructor

Depends on D110852

Comment 4

[Asumu Takikawa]

Attachment: Bug 1703089 - Implement type reflection for WebAssembly.Tag

Depends on D110853

Comment 5

[Asumu Takikawa]

Recently the JS API formal spec (https://github.com/WebAssembly/exception-handling/pull/86), proposal overview (https://github.com/WebAssembly/exception-handling/pull/154), and WPT tests (https://github.com/WebAssembly/exception-handling/pull/155) were merged into the exception handling proposal.

Given that milestone, I marked the attached patches as ready for review. I've tested the patches against the spec tests, which should get merged into the main WPT repo at some point. I'll also rebase these patches soon as well.

Comment 6

[Asumu Takikawa]

Attachment: Bug 1703089 - Update WPT test metadata for Wasm exceptions JS API

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8008c66d883
Implement WebAssembly.Exception constructor r=rhunt
https://hg.mozilla.org/integration/autoland/rev/26fc35525a71
Add WebAssembly.Exception methods r=rhunt
https://hg.mozilla.org/integration/autoland/rev/5a5a33fbb176
Implement WebAssembly.Tag constructor r=rhunt
https://hg.mozilla.org/integration/autoland/rev/7ded9f637e58
Implement type reflection for WebAssembly.Tag r=rhunt
https://hg.mozilla.org/integration/autoland/rev/ac4000f104a3
Update WPT test metadata for Wasm exceptions JS API r=rhunt

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c8008c66d883
https://hg.mozilla.org/mozilla-central/rev/26fc35525a71
https://hg.mozilla.org/mozilla-central/rev/5a5a33fbb176
https://hg.mozilla.org/mozilla-central/rev/7ded9f637e58
https://hg.mozilla.org/mozilla-central/rev/ac4000f104a3