1717118 - Implement renaming of "events" to "tags" in Wasm exceptions proposal

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P2)

Description

[Asumu Takikawa]

There has been a spec discussion of whether to rename the concept of "events" in the Wasm exception handling proposal (https://github.com/WebAssembly/exception-handling/issues/159) and consensus seems to be to rename them to "tags".

(The motivation behind "tags" is to use a generic enough name that it can be used for other future proposals while avoiding confusion with other concepts called "events" in JS)

There are pull requests to implement this change in the spec, LLVM, and binaryen: https://github.com/WebAssembly/exception-handling/issues/159#issuecomment-863099331

This bug is for handling this change in SpiderMonkey.

Comment 1

[Asumu Takikawa]

My plan was to initially leave text format tests as-is (except for changing error messages where needed) and just implement the change for the engine until the renaming is also implemented in wasm-tools/wat.

Comment 2

[Asumu Takikawa]

Attachment: Bug 1717118 - Part 1, rename JS API classes for exceptions

The Wasm exception handling spec has changed to rename "events"
to "tags". As a result, WebAssembly.Exception gets renamed
to WebAssembly.Tag and WebAssembly.RuntimeException becomes
WebAssembly.Exception.

Comment 3

[Asumu Takikawa]

Attachment: Bug 1717118 - Part 2, rename "event" to "tag" throughout

The concept of "events" in the Wasm exception handling proposal
has been renamed to "tags". This commit implements this renaming
in most cases (an exception is text format tests).

Depends on D118281

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:asumu, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Asumu Takikawa]

This patch is just waiting to land and the delay is mostly just due to timing. It's been recently rebased and still relevant, so I'll clear the needinfo.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49a2b786ffb3
Part 1, rename JS API classes for exceptions r=rhunt
https://hg.mozilla.org/integration/autoland/rev/41ea9227d3e6
Part 2, rename "event" to "tag" throughout r=rhunt

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/49a2b786ffb3
https://hg.mozilla.org/mozilla-central/rev/41ea9227d3e6