1703105 - Vendor the SIMD spec test suite

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P1)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

Lars added a snapshot of the SIMD spec test suite using a custom translator. We should find a way to vendor the latest version using our standard tools.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Add testing utilities for running wasm spec test suite. r?lth

This commit adds new utilities for running the wasm spec test suite with
a custom wast2js translator.

The overall approach is to re-use WebAssembly.Global as a tagged
value container so that JS may examine and create these values
in a lossless manner.

Specifically:

• wasmGlobalsEqual - compares two globals for equality
• wasmGlobalToString - debugging util for raw representation details
• wasmGlobalFromArrayBuffer - create a POD value type from bytes
• wasmGlobalExtractLane - extract a lane from a v128 value, as a global
• wasmLosslessInvoke - call a wasm function, taking globals as parameters and
  returning globals as results.

See the new test harness [1] for context of how these functions will
be used.

The addition of wasmLosslessInvoke causes a slight tweak to the stub
layer so that interpreter entries can pass and receive v128 values. This
functionality is only allowed for wasmLosslessInvoke and is guarded
against explicitly.

[1] https://github.com/eqrion/wasm-generate-testsuite/blob/master/wast2js/src/harness.js

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Stop vendoring duplicate WPT version of spec tests. r?lth

We have a duplicate copy of the *.wast tests in mozilla's private WPT
folder. I don't think we get anything out of this and it's more work to
get the wast2js converter working with it, so I think we should drop
this for now.

Depends on D111225

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Vendor spec tests with new translation tool. r?lth

This commit uses the new version of wasm-generate-testsuite which uses
our new wast2js [1] tool to vendor the spec tests.

[1] https://github.com/eqrion/wasm-generate-testsuite/blob/master/wast2js/src/convert.rs

Depends on D111226

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Update spec/reftypes/bulk-memory pinned version for spec tests. r?lth

This commit updates the pinned version of the spec repo to the latest
version. This allows us to remove the separate reftypes/bulk-memory
repo's, as they are no merged in 'spec'.

Depends on D111227

Comment 5

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Start vendoring simd proposal. r?lth

This commit adds the SIMD proposal to the vendored test suites.

Depends on D111228

Comment 6

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Update wat to latest version. r?lth

Some SIMD instructions rely on a newer version of wat then we
have vendored.

Depends on D111229

Comment 7

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Remove old generated import of SIMD spec tests. r?lth

These should be superseded by the new test generator.

Depends on D111226

Comment 8

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Move generate-spectest tool into tree. r?lth

This commit moves the wasm-generate-testuite [1] tool into the
tree so that we have everything we need to update spectests in
one place. Documentation is updated.

Depends on D111305

Comment 9

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Update SIMD tests for renamed iXX.widen_YY instructions. r?lth

The i16x8.widen_XX and i32x4.widen_XX instructions were renamed to use
the word 'extend' instead of 'widen'. This commit updates the tests so they
pass with the new wat version.

Depends on D111230

Comment 10

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1703105 - wasm: Fix cranelift validation for global.set. r?lth

Cranelift uses global.isConstant() for determining if the global is mutable or not.

This isn't correct, and causes a spec-test failure when the global is an import.

Depends on D111307

Comment 11

[Ryan Hunt [:rhunt] (on leave until early May)]

Going to try a staged landing to workaround a lando timeout.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49ebd97ac21c
wasm: Add testing utilities for running wasm spec test suite. r=lth
https://hg.mozilla.org/integration/autoland/rev/49a1e34aee01
wasm: Stop vendoring duplicate WPT version of spec tests. r=lth
https://hg.mozilla.org/integration/autoland/rev/d9a51b12fcb0
wasm: Remove old generated import of SIMD spec tests. r=lth
https://hg.mozilla.org/integration/autoland/rev/f9ac5d079c06
wasm: Move generate-spectest tool into tree. r=lth

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/49ebd97ac21c
https://hg.mozilla.org/mozilla-central/rev/49a1e34aee01
https://hg.mozilla.org/mozilla-central/rev/d9a51b12fcb0
https://hg.mozilla.org/mozilla-central/rev/f9ac5d079c06

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cca008d7f328
wasm: Vendor spec tests with new translation tool. r=lth
https://hg.mozilla.org/integration/autoland/rev/aa32e7b38f0b
wasm: Update spec/reftypes/bulk-memory pinned version for spec tests. r=lth
https://hg.mozilla.org/integration/autoland/rev/72cec027290d
wasm: Start vendoring simd proposal. r=lth
https://hg.mozilla.org/integration/autoland/rev/083c43004487
wasm: Update wat to latest version. r=lth
https://hg.mozilla.org/integration/autoland/rev/81a79723c4ab
wasm: Update SIMD tests for renamed iXX.widen_YY instructions. r=lth
https://hg.mozilla.org/integration/autoland/rev/123165ef9d6a
wasm: Fix cranelift validation for global.set. r=lth

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cca008d7f328
https://hg.mozilla.org/mozilla-central/rev/aa32e7b38f0b
https://hg.mozilla.org/mozilla-central/rev/72cec027290d
https://hg.mozilla.org/mozilla-central/rev/083c43004487
https://hg.mozilla.org/mozilla-central/rev/81a79723c4ab
https://hg.mozilla.org/mozilla-central/rev/123165ef9d6a

Comment 16

[Ryan Hunt [:rhunt] (on leave until early May)]

All patches are now landed.