1703172 - Proton info bars need role="alert"

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[James Teh [:Jamie]]

The Proton info bars need role="alert" on the container for the message and buttons. This allows screen readers to report them automatically when they appear, as well as allowing them to report the message text (since it isn't focusable).

One place this could go is on the <div class="container infobar".

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1703172: Set role="alert" on Proton info bars.

This allows screen readers to report info bars automatically when they appear.
It also allows the message text to be reported, which would normally be missed because it isn't focusable.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45b6eccfb174
Set role="alert" on Proton info bars. r=Jamie

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/45b6eccfb174

Comment 4

[Peter Magyari (Desktop QA)]

I've attempted to verify the fix using Beta 89.0b2 (20210420191345) and Nightly 90.0a1 on the following OS'es and there were several outcomes:

-MacOS 11 (screen-reader) the alert does get read as soon as it pops up but the buttons are read twice
-Ubuntu 20.04 (built in screen-reader) it only announces "alert" when the infobar pops up, doesn't read the notification itself
-Windows 10 (narrator) it announces "alert" and it reads the main string, it also narrates some text which is not visible before each button on the infobar

Comment 5

[James Teh [:Jamie]]

Thanks for testing. Of these issues, the one that worries me the most is Ubuntu, but they're all not great.

Would you mind filing these as three separate bugs (since I suspect the fixes might sadly all be a bit different), and for each, also providing the results when Proton is disabled? Thanks.

Comment 6

[James Teh [:Jamie]]

(In reply to Peter_M from comment #4)

-Windows 10 (narrator) it announces "alert" and it reads the main string, it also narrates some text which is not visible before each button on the infobar

Also, in the Narrator bug, could you specify the invisible text that gets read? Thanks.

Comment 7

[Peter Magyari (Desktop QA)]

Sure, I'll log those three bugs separately.

I've tested it using multiple infobars, which have one or multiple buttons on them and narrator adds "edit" before the "first button" and "alt+random letter" before each of the other buttons available on the infobar (including the close "X" button)