1702962 - Screen readers won't read infobar button strings

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user uses a screen reader with the browser and has various infobars displayed, the screen reader will not read them properly.

Affected versions

• Nightly v88.0a1

Affected platforms

• all

Preconditions:

• Make sure you have the following preferences set to true:
  browser.proton.enabled
  browser.proton.infobars.enabled
  devtools.chrome.enabled
• Install a screen reader if it isn't already available.

Steps to reproduce

1. Start a screen reader (Orca for ubuntu, NVDA for Windows, Screen Reader for Mac OS)
2. Launch browser.
3. Trigger some infobars:
   • Open the browser using a new profile; when a new tab is opened, the Default Browser infobar is displayed.
   • Open the Multiprocess Browser Console and paste: gStoragePressureObserver.observe({QueryInterface: () => ({data:5368709119})}, "QuotaManager::StoragePressure")
   • Open the Multiprocess Browser Console and paste: CaptivePortalWatcher._showNotification()
   • Load: Navigate to http://www.dummysoftware.com/popupdummy_testpage.html
4. Focus on the infobars/infobar information using keyboard navigation and/or hovering it with the cursor.

Expected result

• Both navigation methods properly offer the relevant information to the user.

Actual result

• Some buttons are not being read.

Regression range

• This issue occurs ONLY with Proton enabled.

Additional notes

• Upon investigation it was observed that the "Set as default" button from the Default browser infobar is read, comparing to the others. It is assumed that the light-colored (blue) buttons are read, but the gray ones aren't.

Comment 1

[James Teh [:Jamie]]

These Proton info bars are all kinds of broken in terms of a11y. Aside from the buttons being unlabelled, there's no alert role, so screen reader users aren't alerted when they appear and they also can't read the text of the notification even when they focus it.

Comment 2

[James Teh [:Jamie]]

A11y also can't seem to get the access keys for these buttons.

Comment 3

[James Teh [:Jamie]]

[Tracking Requested - why for this release]: If Proton info bars get enabled, they will be completely inaccessible to screen reader users.

Comment 4

[Romain Testard [:RT]]

Asa, this is a bad regression for screen reader, should this be blocking us from shipping MR1?

Comment 5

[Tyler Duzan]

I believe this is a blocker, am marking this as P1. Asa can you review for a11y severity/priority?

Comment 6

[Mark Striemer [:mstriemer]]

This is fixed after bug 1702327 for me, do you mind retesting?

Comment 7

[James Teh [:Jamie]]

(In reply to Mark Striemer [:mstriemer] from comment #6)

This is fixed after bug 1702327 for me, do you mind retesting?

I verified the fix; thanks. Note that the other issues I mentioned (comment 1, comment 2) are just as severe and don't yet have fixes landed, but we have separate bugs for those now.

Comment 8

[Peter Magyari (Desktop QA)]

Verified the fix using Nightly 89.0a1 (20210409092020) on Windows 10, MacOS 11 and Ubuntu 20.04