1703215 - Evaluate the usefulness of toolkit/mozapps/extensions/test/mochitest/test_bug887098.html

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Christoph Kerschbaumer [:ckerschb]]

Within Bug 1670244 we are starting to perform IPC based Principal vetting when receiving a Principal from the Content Process. In turn, this hardening effort will effectively block content to load about:mozilla as requested by this line:
SpecialPowers.wrap(iwin).location.href = "about:mozilla";

Ultimately opening up the question if that test is still relevant. For now we will explicitly opt-out of perform IPC based principal vetting for the test, but we should re-evaluate how useful that test in it's current form is. Options are (a) re-writing, (b) removing.

Comment 1

[Gregory Pappas [:gregp]]

With the InstallTrigger implementation being disabled everywhere (bug 1772901), is this test still useful?

Comment 2

[Tom Ritter [:tjr]]

We should get a peer to review, but I think yes, we can delete the test.

Comment 3

[Tom Schuster [PTO]]

The current state of InstallTrigger seems to be that the property exists (again, see bug 1950440), but it doesn't do anything (bug 1772901) and window.InstallTrigger === null.

I would like to remove this test now, because it's blocking the removal of the dom.security.enforceIPCBasedPrincipalVetting pref.

Comment 4

[Tom Schuster [PTO]]

Attachment: Bug 1703215 - Remove test_bug887098.html. r?rpl!,tjr!

window.InstallTrigger is just null nowadays and this test blocks the
removal of the dom.security.enforceIPCBasedPrincipalVetting pref.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/94c689d599ce
https://hg.mozilla.org/integration/autoland/rev/58722d4f462b
Remove test_bug887098.html. r=rpl,tjr

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/58722d4f462b