1703239 - Screen Readers will not read the Finish Account Setup / You've been disconnected notifications from the Hamburger menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Rares Doghi, Desktop QA]

[Affected platforms]:
Platforms: Windows 10

[Preconditions]:

Reach about:config and set browser.proton.enabled = true

[Steps to reproduce]:

1. Launch the Firefox Browser and Create a new account without verifying it.
2. Reach the Fxa Notification from the Hamburger menu using NVDA or other screen readers.
3. Restart the Browser and reach the Fxa Notification from the Hamburger menu using NVDA.

Expected Result:
NVDA should read "Finish account setup" or "You've been disconnected" messages without issues.

Actual Results:
NVDA only reads "Sign in".

Comment 1

[Marcela (Please NI request to Brindusa Tot)]

I was able to reproduce it on macOS 11 Big Sur using VoiceOver

Comment 2

[Molly Howell (she/her) (no longer active)]

For the record, I've confirmed that this is a regression in the Proton app menu; with the Proton pref disabled, the button label that gets read out is the expected "Finish account setup", etc., but in the Proton menu it's always "Sign in".

Comment 3

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1703239 - Expose the accounts error messages in the app menu to screen readers. r=emalysz

The Proton app menu version of the accounts button doesn't need the button
label attribute for display purposes, but if the attribute isn't updated when
an error happens, then accessibility tools only ever see the "Sign in" text.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7729d9f5878d
Expose the accounts error messages in the app menu to screen readers. r=emalysz

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7729d9f5878d

Comment 6

[Rares Doghi, Desktop QA]

Hi Molly, the NVDA reads the correct notification message now but the email is not read at all in the Hamburger menu, only in the FxA menu, should we confirm this issue as fixed and add a new issue related to the email text ? in older builds This notification would not show the email at all but with the new Design the email is also there and its not read by the screen reader.

Comment 7

[Molly Howell (she/her) (no longer active)]

Please file that as a new bug, thanks.

Comment 8

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in our latest build 89.0a1 (2021-04-12)