Closed Bug 1703302 Opened 2 years ago Closed 2 years ago

Replace app.background.experimental with app.update.background.scheduling.enabled

Categories

(Toolkit :: Application Update, task)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: nalexander, Assigned: bytesized)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Now that --backgroundtask backgroundupdate and task scheduling have landed, we can display the UI more generally. That means removing app.update.background.experimental (and have it just be AppConstants.MOZ_UPDATE_AGENT, I guess).

Assignee: nobody → ksteuber
Status: NEW → ASSIGNED

Kirk, can you verify that the BackgroundAppUpdate=true policy always shows and disables the "When not running" check box? When BackgroundAppUpdate=false do we hide the check box or always show it and disable it?

Flags: needinfo?(ksteuber)

We actually have an automated test for this, here. It passes with this patch applied.

When any policy affecting the control is active, we hide the whole control. This is consistent with what we do for other update controls that can be affected by policy.

Flags: needinfo?(ksteuber)

(In reply to Kirk Steuber (he/him) [:bytesized] from comment #3)

We actually have an automated test for this, here. It passes with this patch applied.

When any policy affecting the control is active, we hide the whole control. This is consistent with what we do for other update controls that can be affected by policy.

Thanks for confirming our standard in this space.

After talking this over with Nick, we want this to continue to be pref'ed off for now. But we would like it to be controlled by the same pref that controls the Background Update Task scheduling default: app.update.background.scheduling.enabled. This will allow us to use that pref with Normandy when we roll this feature out, enabling both the default scheduling and the UI.

Summary: Remove app.background.experimental to show background update UI unconditionally → Replace app.background.experimental with app.update.background.scheduling.enabled
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a1b2c95538e
Remove app.background.experimental to show background update UI unconditionally r=nalexander,preferences-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1708755
You need to log in before you can comment on or make changes to this bug.