Closed Bug 1703366 Opened 4 years ago Closed 4 years ago

Dark theme doesn't use the right colors

Categories

(Thunderbird :: Theme, defect)

Thunderbird 89
Desktop
Unspecified
defect

Tracking

(thunderbird_esr78 unaffected, thunderbird88 unaffected, thunderbird89 affected)

RESOLVED FIXED
89 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird88 --- unaffected
thunderbird89 --- affected

People

(Reporter: sdk, Assigned: Paenglab)

References

Details

Attachments

(4 files)

Text color for the active tab and the tree folder now use rgb(212,212,212) instead of #f9f9fa. It seems to have been introduced by https://hg.mozilla.org/comm-central/pushloghtml?fromchange=d310d9c9341cfa0c7b4ad31463a69b545549f600&tochange=9cca2363d7e1537b736b911b766cdf950ad68b9b

Edit

It seems like a lot of other elements in the UI are affected by the changes related to upstream/Proton.

Attached image tb-active-tab-text.png
Attached image tb-tree-folder-text.png
Component: General → Theme
Summary: Active tab and tree folder text doesn't use the right foreground color → Dark theme doesn't use the right colors

Photon uses a darker toolbar text color. Removed it to get the old color back.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9214079 - Flags: review?(alessandro)
Comment on attachment 9214079 [details] [diff] [review] 1703366-toolbar-text-color.patch Review of attachment 9214079 [details] [diff] [review]: ----------------------------------------------------------------- This doesn't solve the text color of the currently selected tab bar.
Attachment #9214079 - Flags: review?(alessandro)

78 vs Trunk
The Text in the toolbar is too dark.

Comment on attachment 9214079 [details] [diff] [review] 1703366-toolbar-text-color.patch Review of attachment 9214079 [details] [diff] [review]: ----------------------------------------------------------------- Nevermind, I needed to deactivate and reactive the dark mode to let the changes take place. This is good.
Attachment #9214079 - Flags: review+

(In reply to Alessandro Castellani [:aleca] from comment #6)

Comment on attachment 9214079 [details] [diff] [review]
1703366-toolbar-text-color.patch

Review of attachment 9214079 [details] [diff] [review]:

Nevermind, I needed to deactivate and reactive the dark mode to let the
changes take place.
This is good.

Yes, I bumped the version to 1.2 in the Photon patch and the ones using it already need to disable/enable the theme to apply the new colour after this patch.

Target Milestone: --- → 89 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/19d4fe20dbe4
Don't use the Photon toolbar text color. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: