1703384 - Failure in browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js with proton urlbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Marco Bonardo [:mak]]

There's a failure in browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js when graduating the proton urlbar.

Comment 1

[Harry Twyford]

The issue here is

FAIL Result a11y label should be: <title>— Switch to Tab - Got "about: robots Switch to Tab", expected "about: robots— Switch to Tab"

This is because we're no longer showing the title separator before the switch-to-tab action text. We should:

1. Verify with Product and UX that we're sticking with the chiclet-style switch-to-tab action text
2. If yes, check if there's a difference between the way screen readers read "<title>— Switch to Tab " and "<title> Switch to Tab"
   2a) If no, just change the test.
   2b) If yes, ensure the title separator isn't hidden to screen readers.

Comment 2

[Harry Twyford]

We're sticking with the switch-to-tab chiclet design, i.e. we're removing the title separator. Also, there's a difference in the way VoiceOver reads "<title>— Switch to Tab " and "<title> Switch to Tab". So we're going with option (2b).

Comment 3

[Harry Twyford]

Attachment: Bug 1703384 - Make the switch-to-tab title separator transparent so it stays in the accessibility tree. r?mak,dao

We want the screen reader to pause between announcing the result title and the switch-to-tab action text. I considered:

1. Set position:absolute on the title separator and left: -999px or the like. This works but is bad semantically IMO.
2. Continue to set visibility: hidden on the title separator. Insert an em dash into the aria-label on the row/action text, so screen readers pause. This would work, but is more complex. It's not clear in the CSS what's happening in the a11y tree.
3. Take advantage of the fact that we know from the CSS exactly how big the title-separator is. The title-separator is an em dash with a 0.4em margin. Em dashes are, by definition, exactly 1em wide. Convenient!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/632daf704310
Make the switch-to-tab title separator transparent so it stays in the accessibility tree. r=mak

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/632daf704310