1703274 - Graduate browser.proton.urlbar.enabled to browser.proton.enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Marco Bonardo [:mak]]

We got approval to move behind the main proton pref. Note on css we should change -moz-proton-urlbar media queries to -moz-proton
We should ensure to not regress bug 1700112 with new failing urlbar tests.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Marco, could you take this and put up a patch for review? Hoping to land this today or tomorrow at the latest.

Comment 2

[Marco Bonardo [:mak]]

Yeah ok.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1703274 - Enable Proton Urlbar. r=jaws

Comment 5

[Marco Bonardo [:mak]]

in case you're looking for logs of the failures in dependencies, this was my last push to Try https://treeherder.mozilla.org/jobs?repo=try&revision=c8e8661a9bac176e0b3d18dc10f693998aa45d06

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd396182f84a
Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing wpt failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=wpt&revision=e422727ceb80b10aa3a1353c06be13bcca69ec41&test_paths=%2Fcss%2Fcss-shapes%2Fshape-outside&selectedTaskRun=Z5uai0rtR6SE1HZEXCCQsg.0

Failure logs: https://treeherder.mozilla.org/logviewer?job_id=335979460&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=335978874&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/1cfcf8190e7c000c193a916c5ab51d399e553adc

Comment 8

[Marco Bonardo [:mak]]

How can this have caused wpt failures?

Comment 9

[Harry Twyford]

Might this be due to bug 1702830? Specifically the patch in comment 15. If that patch changed expectations around intermittents, maybe this patch was just the first failure under the new intermittent criteria?

Comment 10

[Marco Bonardo [:mak]]

The wpt failures for reference:
TEST-UNEXPECTED-FAIL | /css/css-values/viewport-units-css2-001.html | vh length applied to border-top-width - assert_equals: expected 94 but got 93
TEST-UNEXPECTED-FAIL | /css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000.html | View relative units - computed - assert_equals: expected "polygon(12.8px 9.38px, 9.38px 12.8px)" but got "polygon(12.8px 9.367px, 9.367px 12.8px)"

Comment 11

[Emilio Cobos Álvarez (:emilio)]

It seems this changes the viewport size in testharness.js tests in a way that makes these tests fail. These tests rely on particular rounding precision which is not specified, so I think it should be fine to update the expectations.

Comment 12

[Marco Bonardo [:mak]]

Attachment: Bug 1703274 - Update WPT tests expectations. r=emilio

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd058bc4e3ae
Update WPT tests expectations. r=emilio
https://hg.mozilla.org/integration/autoland/rev/135c5397086d
Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fd058bc4e3ae
https://hg.mozilla.org/mozilla-central/rev/135c5397086d