Closed Bug 1703385 Opened 4 years ago Closed 4 years ago

Failure in browser/components/urlbar/tests/browser/browser_searchMode_no_results.js with proton urlbar

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Iteration:
89.2 - Apr 5 - Apr 18
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mak, Assigned: bugzilla)

References

Details

(Whiteboard: [proton-address-bar])

Attachments

(1 file)

Bug 1703385 - Initialize UrlbarSearchOneOffs._webEngines in the constructor. r?mak!
48 bytes, text/x-phabricator-request
Details | Review

There's a failure in browser/components/urlbar/tests/browser/browser_searchMode_no_results.js when graduating the proton urlbar

Priority: -- → P1
Assignee: nobody → htwyford
Severity: -- → S3
Status: NEW → ASSIGNED
Iteration: --- → 89.2 - Apr 5 - Apr 18
Points: --- → 2

The issue here is that _rebuildEngineList is being called before updateWebEngines. updateWebEngines initializes _webEngines. When _rebuildEngineList tries to iterate over _webEngines, an exception is thrown.

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e568fb7b92f
Initialize UrlbarSearchOneOffs._webEngines in the constructor. r=mak

https://hg.mozilla.org/mozilla-central/rev/8e568fb7b92f

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: