1703388 - Failure in browser/modules/test/browser/browser_PageActions_contextMenus.js with proton urlbar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Marco Bonardo [:mak]]

There's failures in browser/modules/test/browser/browser_PageActions_contextMenus.js when graduating the proton urlbar

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1703388 - Fix failures in browser/modules/test/browser/browser_PageActions_contextMenus.js with proton urlbar.

This builds on D111205 by factoring out some initialization into a new
initPageActionsTest() in head.js. I'll need to use it in
browser_PageActions_newWindow.js too (bug 1703389).

Pre-Proton, there are 4 page action context menu items:

• Add to Address Bar
• Remove from Address Bar
• Manage Extension
• Remove Extension

Regardless of Proton, there are two context menus, one for buttons in the urlbar
and one for items in the page action panel. They're actually the same menu of
course.

This test currently checks each menu item in both context menus for a
non-built-in action except for the Remove Extension menu item. In Proton, we
don't need to check Add or Remove, so I modified the test to skip them. I also
added a check for the Remove Extension menu item. The test now must actually
create an extension with a page action to test the context menu because in
Proton only actions with extension IDs get the context menu (bug 1700364). Since
the test is creating an extension anyway, testing the Remove Extension menu item
isn't too hard.

Depends on D111205

Comment 2

[Drew Willcoxon :adw]

Proton: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dca375e0f4b83ad769b939e88766a381d071e8f3

No Proton: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4beddcc4f52263a7d68d2bbc3134aa4f8f148a2e

Comment 3

[Marco Bonardo [:mak]]

proton is now enabled in nightly fwiw, proton.urlbar is not.

Comment 4

[Drew Willcoxon :adw]

Ah thanks. I need to update my Nightly! And my m-c apparently... although I think I did notice some changes actually.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a655c3f81a83
Fix failures in browser/modules/test/browser/browser_PageActions_contextMenus.js with proton urlbar. r=mak

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a655c3f81a83