1703501 - Can only move an account one step at a time by keyboard

Status: VERIFIED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Martin Giger [:freaktechnik]]

Currently, the account manager gets reloaded every time the accounts are reordered. This leads to the focus being lost and thus only one move is possibly with the keyboard shortcut.

Magnus pointed out that it also leads to the account list getting scrolled to the top, which can also be confusing in the drag'n'drop case.

The function that reloads the account manager is https://searchfox.org/comm-central/rev/36bc68ce1085a077c3e676153be5c30163a09d9e/mailnews/base/prefs/content/AccountManager.js#878-890

I'm not sure if the reload is done to avoid any state inconsistencies, since currently the function is only called when the order is changed from within the account manager's own tree.

Comment 1

[Magnus Melin [:mkmelin]]

Martin, can you check if we can improve this?

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1703501 - Allow moving an account multiple steps by keyboard. r=mkmelin

Moving accounts by keyboard does not work correctly after adding items, even though the code tries to do the right thing, the nodes end up in the wrong places.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e2c9f4b952a
Allow moving an account multiple steps by keyboard. r=mkmelin

Comment 4

[Uplift Request]

This has been on beta for a while, so time for the backport? Lots of other bugs already had ESR91 approved.

Comment 5

[Magnus Melin [:mkmelin]]

Leaving for patch author to request uplift.

Comment 6

[Martin Giger [:freaktechnik]]

Comment on attachment 9231451 [details]
Bug 1703501 - Allow moving an account multiple steps by keyboard. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Can only move an account one step by keyboard before having to reacquire focus of it.
Testing completed (on c-c, etc.): automated test, nightly, beta
Risk to taking this patch (and alternatives if risky): low, worst case the wrong account is selected or an account manager tree might be out of sync of the account order.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9231451 [details]
Bug 1703501 - Allow moving an account multiple steps by keyboard. r=mkmelin

[Triage Comment]
Approved for esr91

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.1.0:
https://hg.mozilla.org/releases/comm-esr91/rev/b17476b41fed

Comment 9

[WaltS48 [:walts48]]

Verified testing the 91.1.0 release candidate on Windows 10.