1706849 - Reordering accounts in the Account Settings tab is broken

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Geoff Lankow (:darktrojan)]

Dragging and dropping an account to reorder it always puts the dragged account at the top of the list. There's also no drag position indicator showing.

Comment 1

[Magnus Melin [:mkmelin]]

It seems to be working, but yeah no indicator (I think we never got that working).
That it refreshes the whole tree on drop gives some bad ux. See bug 1703501 as well.

Comment 2

[Martin Giger [:freaktechnik]]

I can't confirm the "always at the top of the list" behavior. The way the code works iirc is that it puts the dragged account to the position of the hovered account and pushes the hovered account down.

Comment 3

[José M. Muñoz]

See also bug 1709370 and bug 1708283.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1706849 - Fix reordering accounts by drag-n-drop in the Account Settings tab. r=freaktechnik

The code to determine the dropped position didn't account for collapsed rows. While here I added a marker to show where a drop would occur.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/da5dbce71dfb
Fix reordering accounts by drag-n-drop in the Account Settings tab. r=freaktechnik