Closed Bug 1703651 Opened 3 years ago Closed 3 years ago

Update toolbar button fill opacity to match Proton specs.

Categories

(Firefox :: Theme, enhancement, P1)

Product:
Firefox
Component:
Theme
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: sfoster, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-toolbar][proton-icons])

Attachments

(1 file)

Bug 1703651 - Proton toolbar icons should have no fill opacity by default. r?harry!
48 bytes, text/x-phabricator-request
Details | Review

We currently have a default fill-opacity for icons toolbarbuttons set by the --toolbarbutton-icon-fill-opacity variable, at a range of values depending on the platform. For Proton, this should default to 1 - just like we currently do for lw-themes.

We still want to maintain the ability to set icon fill opacity from CSS, so icons should keep their fill="context-fill-opacity" attributes and we should continue to set-moz-context-properties: fill, fill-opacity;`. in the relevant CSS.

Blocks: proton-icons
Severity: -- → S3
Priority: -- → P1
Assignee: nobody → mconley
Blocks: 1703914
Blocks: 1702289
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c42470b8ec4c
Proton toolbar icons should have no fill opacity by default. r=harry,desktop-theme-reviewers

https://hg.mozilla.org/mozilla-central/rev/c42470b8ec4c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: