Closed
Bug 1703914
Opened 4 years ago
Closed 3 years ago
Remove --toolbarbutton-icon-fill-opacity CSS variable
Categories
(Firefox :: Theme, task, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
92 Branch
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: mconley, Assigned: bigiri)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-cleanups])
Attachments
(1 file)
In bug 1703651, we made it so that most icons have an opacity of 1 by default. We did this by updating the --toolbarbutton-icon-fill-opacity CSS variable, mainly so that we could continue to support the non-Proton styles simultaneously.
Once Proton ships and hits release, we should consider retiring the --toolbarbutton-icon-fill-opacity CSS variable entirely, since it's probably not needed anymore.
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1103
|
||
Updated•4 years ago
|
Priority: -- → P3
|
||
Updated•3 years ago
|
Points: --- → 1
|
|
||
Comment 1•3 years ago
|
||
https://searchfox.org/mozilla-central/search?q=toolbarbutton-icon-fill-opacity shows it is only ever set to 1 now, so we can just remove it.
Summary: Consider removing --toolbarbutton-icon-fill-opacity CSS variable → Remove --toolbarbutton-icon-fill-opacity CSS variable
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → bigiri
|
||
Updated•3 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•3 years ago
|
||
All uses of --toolbarbutton-icon-fill-opacity have been replaced with 1 and all declarations of it have been removed.
Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/770273d8e001
Removed --toolbarbutton-icon-fill-opacity CSS var r=mconley,desktop-theme-reviewers,dao
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•