Closed Bug 1703711 Opened 4 years ago Closed 4 years ago

Checkbox label wrapping causes layout issues in in-content dialogs

Categories

(Firefox :: Tabbed Browser, defect, P2)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-modals] [priority:2a])

Attachments

(2 files)

After bug 1694661 the checkbox text for tab-switch checkboxes is longer. We determine the height of the dialog based on the unwrapped label, and if the label then wraps (depends on the length of the domain...) then the height computation for the dialog breaks and we end up with less height than we want, which then causes the main #infoBody element to shrink vertically, hiding the main dialog text (d'oh!).

It needs the same CSS fix I applied to #infoBody to deal with this.

Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/91d7b75f26cf fix dialog wrapping issue with checkboxes in in-content prompts, r=jaws https://hg.mozilla.org/integration/autoland/rev/211cd4a12ed5 fix host display name issue with tabswitch permission prompt checkboxes, r=jaws
Priority: -- → P2
Whiteboard: [proton-modals] → [proton-modals] [priority:2a]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: