1703732 - Catch exception in `BackgroundUpdate.jsm:_mirrorToPerInstallationPref` when `BackgroundAppUpdate` policy locks `app.update.background.enabled`

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Nick Alexander :nalexander [he/him]]

The title says it all: BackgroundUpdate.jsm:_mirrorToPerInstallationPref doesn't catch exceptions from UpdateUtils.writeUpdateConfigSettting(...) when BackgroundAppUpdate policy has locked app.update.background.enabled.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1703732 - Catch exception if `BackgroundAppUpdate` policy has locked `app.update.background.enabled`. r?bytesized

There are two parts to this. The first part is simply fixing the
issue, which was an oversight. The second part is rejecting with a
JavaScript Error, which provides a nicely formatted stack in the
browser console, easing debugging.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1689519

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dcd8281b5f22
Catch exception if `BackgroundAppUpdate` policy has locked `app.update.background.enabled`. r=bytesized,application-update-reviewers

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dcd8281b5f22

Comment 5

[Gabi Cheta [:Gabi] Desktop QA]

Confirming that the issues are fixed on Windows 10x64 with 89.0a1 (2021-04-09).
Issues are still reproducible on Windows 7x64 with 89.0a1 (2021-04-09).

Windows7x64 logs from browser console:

• ignoring failure to mirror per-profile pref "app.update.background.scheduling.enabled" default to per-installation pref default "app.update.background.enabled" Error: UpdateUtils.writeUpdateConfigSetting: Unable to change value of setting 'app.update.background.enabled' because it is locked by policy
  writeUpdateConfigSetting resource://gre/modules/UpdateUtils.jsm:393
  _mirrorToPerInstallationPref resource://gre/modules/BackgroundUpdate.jsm:278
  maybeScheduleBackgroundUpdateTask resource://gre/modules/BackgroundUpdate.jsm:331
  task resource:///modules/BrowserGlue.jsm:2540
  _scheduleStartupIdleTasks resource:///modules/BrowserGlue.jsm:2572

• BackgroundUpdate: maybeScheduleBackgroundUpdateTask: not scheduling background update: '["app.update.background.enabled=false"]' BackgroundUpdate.jsm:430
  BackgroundUpdate: maybeScheduleBackgroundUpdateTask: exiting after uncaught exception in maybeScheduleBackgroundUpdateTask!
  Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWinTaskSchedulerService.deleteTask]", result: 2147500037, filename: "resource://gre/modules/TaskSchedulerWinImpl.jsm", lineNumber: 57, columnNumber: 0, data: null, stack: "deletetask@resource://gre/modules/taskschedulerwinimpl.jsm:57:16\ndeletetask:437:31\n", location: XPCWrappedNative_NoHelper }