1703860 - Fix some tests that block turning on Proton doorhangers and context menus by default

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Mike Conley (:mconley) (:⚙️)]

This bug is concerning these tests:

• browser/components/customizableui/test/browser_989751_subviewbutton_class.js
• browser/components/customizableui/test/browser_995164_registerArea_during_customize_mode.js
• browser/components/customizableui/test/browser_overflow_use_subviews.js

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1703860 - Fix some tests that fail when enabling Proton doorhangers and contextmenus. r?jaws!

This updates browser_989751_subviewbutton_class.js to be usable with the new structure of the
Developer Tools panel, and updates browser_overflow_use_subviews.js to use the Library button
instead of the Developer Tools button to avoid having to switch on IDs based on whether or not
Proton is enabled.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

browser/components/customizableui/test/browser_995164_registerArea_during_customize_mode.js didn't fail locally when run in isolation. I believe that failure on try was caused by earlier busted test state.

The patch in this bug, plus the patch in bug 1703870, and the whole directory passes for me locally with both Proton enabled and disabled.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Going to add another patch for browser_toolbarKeyNav.js too.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1703860 - Fix browser_toolbarKeyNav.js so that it works with Proton doorhangers enabled or not. r?jaws!

Depends on D111287

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c277fbe25d5
Fix some tests that fail when enabling Proton doorhangers and contextmenus. r=jaws
https://hg.mozilla.org/integration/autoland/rev/8c406d85b036
Fix browser_toolbarKeyNav.js so that it works with Proton doorhangers enabled or not. r=jaws

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d122c945885
Fix eslint failures in browser_989751_subviewbutton_class.js a=lint-fix

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3c277fbe25d5
https://hg.mozilla.org/mozilla-central/rev/8c406d85b036
https://hg.mozilla.org/mozilla-central/rev/6d122c945885