1704000 - Enable reftests on Android for SW-WR

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Sotaro Ikeda [:sotaro]]

We should be running SW-WR reftests on Android.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: WIP: Bug 1704000 - Enable reftests on Android for SW-WR

Comment 2

[Sotaro Ikeda [:sotaro]]

Just enabling sw-wr reftest caused crash in CompositorOGL::BeginFrame()
https://treeherder.mozilla.org/jobs?repo=try&revision=35f4becd1411f29ce6df944c17a05cc76d4d79c5

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1704000 - RenderCompositorLayersSWGL::BeforeWrRender()

Comment 4

[Phabricator Automation]

Comment on attachment 9215038 [details]
Bug 1704000 - RenderCompositorLayersSWGL::BeforeWrRender()

Revision D111583 was moved to bug 1704431. Setting attachment 9215038 [details] to obsolete.

Comment 5

[Sotaro Ikeda [:sotaro]]

With current patch, test failures were basically addressed. But some apz tests results seem to have problems. Black rectangle exists :(
https://treeherder.mozilla.org/jobs?repo=try&revision=671e4d5541b065bd7248b73d19d433760c3a312a

Comment 6

[Sotaro Ikeda [:sotaro]]

Reftests still have some failures :(

With PBO
https://treeherder.mozilla.org/jobs?repo=try&revision=b8d0a1b6feb80513e91fd0fa56f39dc2f816f129

Without PBO
https://treeherder.mozilla.org/jobs?repo=try&revision=37c7b3d0a7e657b57f13e9882d25c117e10cc325

Comment 7

[Sotaro Ikeda [:sotaro]]

On release build, frequency of failures became less frequent.

https://treeherder.mozilla.org/jobs?repo=try&revision=bb6247a1f2f2b02cb1b0c4be7ca31ea5d69623da

Comment 8

[Sotaro Ikeda [:sotaro]]

zoom performance is not good(bug 1703709). It might be related.

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #6)

Reftests still have some failures :(

With PBO
https://treeherder.mozilla.org/jobs?repo=try&revision=b8d0a1b6feb80513e91fd0fa56f39dc2f816f129

Without PBO
https://treeherder.mozilla.org/jobs?repo=try&revision=37c7b3d0a7e657b57f13e9882d25c117e10cc325

It seems that, azp did not work as expected with sw-wr. But sw-wr does not directly interact with apz.

:hiro, do you have any ideas about what could cause the problem?

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Given that failures happen on tests specifying reftest-async-scroll and those failures are not perma, it's high frequent intermittent, it looks like with SW-WR we take a snapshot before applying the async scroll offset even though it's a sync IPC call, the call ends up deferring the task to the updater thread, that's the problem?

Comment 11

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #10)

Given that failures happen on tests specifying reftest-async-scroll and those failures are not perma, it's high frequent intermittent, it looks like with SW-WR we take a snapshot before applying the async scroll offset even though it's a sync IPC call, the call ends up deferring the task to the updater thread, that's the problem?

And moreover, even if applying the offset value has finished on the updater thread at the moment we take a snapshot, the offset needs to be sampled on the sampler thread, then it needs to be rendered on the renderer thread? I am pretty sure about the sampler thread, but not 100% about the renderer thread.

Comment 12

[Sotaro Ikeda [:sotaro]]

When RenderCompositorOGLSWGL always request full render, the failures did not happen. The problem seems to exist around RenderCompositorOGLSWGL.
https://treeherder.mozilla.org/jobs?repo=try&revision=65962e21ec8f5b2c160f57c72b3b716e82ad4dc9

Comment 13

[Sotaro Ikeda [:sotaro]]

When the problem happened, RenderCompositorLayersSWGL::StartCompositing() was returned early by aNumDirtyRects==0.

• https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/gfx/webrender_bindings/RenderCompositorLayersSWGL.cpp#80

https://treeherder.mozilla.org/jobs?repo=try&revision=28e04ed3b5108980aeeee61482976a2375f1917e

Comment 14

[Sotaro Ikeda [:sotaro]]

Just apz scroll update might not provide dirty rect.

Comment 15

[Sotaro Ikeda [:sotaro]]

Attachment: WIP: Bug 1704000 - Enable reftests on Android for SW-WR

Comment 16

[Sotaro Ikeda [:sotaro]]

APZ test failure was related to skip rendering during taking snapshot.

RendererOGL::UpdateAndRender() does readback with glReadPixels(). If RenderCompositorOGLSWGL skips rendering at RenderCompositorLayersSWGL::StartCompositing(), frambuffer does not have valid rendering. readback image was old data that existed in android BufferQueue.

When rendering was forced during readback, reftest failures were addressed.
https://treeherder.mozilla.org/jobs?repo=try&revision=2abb60075d8af54b17b021e7db42ed08652feeb9

Comment 17

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1704000 - Request rendering for RenderCompositorOGLSWGL::MaybeReadback()

Comment 18

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1704000 - Enable reftests on Android emulator for SW-WR

Comment 19

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1704000 - Update reftest.list

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e6ae945c88a
Enable reftests on Android emulator for SW-WR r=jmaher,gfx-reviewers,bradwerth

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e24c277bcb6c
Update reftest.list r=jmaher,gfx-reviewers,bradwerth

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c05978287481
Request rendering for RenderCompositorOGLSWGL::MaybeReadback() r=gfx-reviewers,bradwerth

Comment 23

[Dorel Luca [:dluca]]

Backed out changeset 8e6ae945c88a (bug 1704000) for Reftest failures on Android. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=340662468&repo=autoland&lineNumber=5695

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=8e6ae945c88a59bdf07606465fc7faed71def91c

Backout:
https://hg.mozilla.org/integration/autoland/rev/92eabce732fb

Comment 24

[Sotaro Ikeda [:sotaro]]

Sorry, I forgot to land dependent patches.

Comment 25

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e24c277bcb6c
https://hg.mozilla.org/mozilla-central/rev/c05978287481

Comment 26

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/jobs?repo=try&revision=67750e4d501c9b55af1094c30e05341b5c7f3dbe

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8da269046d5
Enable reftests on Android emulator for SW-WR r=jmaher,gfx-reviewers,bradwerth

Comment 28

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e8da269046d5