Remove extension-data migration logic from DirectoryInstaller's installAddon method
Categories
(Toolkit :: Add-ons Manager, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | fixed |
People
(Reporter: robwu, Assigned: mathew.hodson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
DirectoryInstaller's installAddon method runs some data migration logic at https://searchfox.org/mozilla-central/rev/5a8487d8e9dd114289083800f723d9c56c9a8003/toolkit/mozapps/extensions/internal/XPIInstall.jsm#3209-3237
This appears to have been introduced in bug 915838 and got removed in part 7 of bug 1447903.
The logic is obsolete and should be removed. Resolving this bug is probably as simple as just removing the referenced lines.
It would also be nice to double-check whether we need to support updated extension IDs (i.e. the existingAddonID option). If the answer is yes, the question is whether we should perform any extension data migration / removal, and/or at the very least introduce a unit test for the scenario.
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
(In reply to Rob Wu [:robwu] from comment #0)
It would also be nice to double-check whether we need to support updated extension IDs (i.e. the
existingAddonIDoption).
I see a check that fails if this.addon.id != this.existingAddon.id. Does that mean we don't need to support that case in installAddon?
|
Reporter | |
Comment 2•3 years ago
|
||
We don't need to support updated add-on IDs. In the past it was a valid case (bug 412819), but not any more after bug 1303418.
It looks like all occurrences of existingAddonID can be removed: https://searchfox.org/mozilla-central/search?q=existingAddonID&redirect=false
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/b0a4dcad04ca Remove unused extension-data migration code. r=robwu
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•