1447903 - Update add-on manager xpcshell tests to use only bootstrapped extensions

Comment on attachment 8961260 [details] Bug 1447903: Part 3a - Refactor test_corrupt.js to not be insane. https://reviewboard.mozilla.org/r/230042/#review235940 This is less insane than it was but maybe it could get even less insane? The contents of `afterRestart` / `afterCorruption` / `afterSecondRestart` are mostly identical for a given addon, the exceptions seem to be due to a bug with themes. How about just having "desiredState" or something and put it some exceptions for themes for now, annotated with the theme selection bug?

Andrew Swan [:aswan]

Comment 39

•

8 years ago

mozreview-review

Comment on attachment 8961261 [details] Bug 1447903: Part 3b - Remove test_bug559800.js, which overlaps with test_corrupt.js. https://reviewboard.mozilla.org/r/230044/#review235950

Attachment #8961261 - Flags: review?(aswan) → review+

Comment hidden (mozreview-request)

Kris Maglione [:kmag]

Assignee

Updated

•

8 years ago

Blocks: 1448221

Andrew Swan [:aswan]

Comment 42

•

8 years ago

mozreview-review

Comment on attachment 8961265 [details] Bug 1447903: Part 4 - Remove xpcshell tests which only apply to restart-required extensions. https://reviewboard.mozilla.org/r/230052/#review236216 ::: toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini (Diff revision 1) > tags = blocklist > [test_gfxBlacklist_prefs.js] > # Bug 1248787 - consistently fails > skip-if = true > tags = blocklist > -[test_install.js] can you just leave this in place here until it gets rewritten in part 22 or whatever it is

Attachment #8961265 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 43

•

8 years ago

mozreview-review

Comment on attachment 8961266 [details] Bug 1447903: Part 5 - Update test_startup to use bootstrapped extensions (but still be insane). https://reviewboard.mozilla.org/r/230054/#review236218 ::: commit-message-af9ef:1 (Diff revision 1) > +Bug 1447903: Part 5 - Update test_startup to use bootstrapped extensions (but still be instane). r?aswan typo

Attachment #8961266 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 44

•

8 years ago

mozreview-review

Comment on attachment 8961267 [details] Bug 1447903: Part 6a - Refactor test_manifest.js to not be insane. https://reviewboard.mozilla.org/r/230056/#review236220

Attachment #8961267 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 45

•

8 years ago

mozreview-review

Comment on attachment 8961268 [details] Bug 1447903: Part 6b - Roll test_targetPlatforms.js into test_manifest and make non-insane. https://reviewboard.mozilla.org/r/230058/#review236222 what about the `do_check_[not_]?in_crash_annotation` stuff? that's covered in plenty of other places i guess... ::: toolkit/mozapps/extensions/test/xpcshell/test_manifest.js:596 (Diff revision 1) > + maxVersion: "1" > + }] > + }, > + > + expected: { > + appDisabled: !true, how about just false? likewise below

Attachment #8961268 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 46

•

8 years ago

mozreview-review

Comment on attachment 8961269 [details] Bug 1447903: Part 6c - Update test_manifest.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230060/#review236226

Attachment #8961269 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 47

•

8 years ago

mozreview-review

Comment on attachment 8961270 [details] Bug 1447903: Part 7 - Update simpler tests to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230062/#review236228 ::: toolkit/mozapps/extensions/test/xpcshell/test_bug449027.js (Diff revision 1) > - for (i = 0; i < ADDONS.length; i++) { > - if (ADDONS[i][test] && !ADDONS[i][lastTest]) { > - if (!gNewBlocks.includes(ADDONS[i].name + " " + ADDONS[i].version)) > - do_throw("Addon " + (i + 1) + " should have been listed in the blocklist notification for test " + test); > - expected++; > - } > - } what does this have to do with boostrapped-ness? ::: toolkit/mozapps/extensions/test/xpcshell/test_dataDirectory.js:1 (Diff revision 1) > /* This Source Code Form is subject to the terms of the Mozilla Public can we just remove this test (and the corresponding code in XPIProvider)? ::: toolkit/mozapps/extensions/test/xpcshell/test_invalid_install_rdf.js:87 (Diff revision 1) > + }); > + > equal(hasChromeEntry("foo-langpack"), false, > "Should not foo-langpack resource before AOM startup"); > + equal(hasChromeEntry("foo-legacy-legacy"), false, > + "Should not foo-legacy-legacy resource before AOM startup"); we're missing a verb here (and in the test above)

Andrew Swan [:aswan]

Comment 48

•

8 years ago

mozreview-review

Comment on attachment 8961271 [details] Bug 1447903: Part 8a - Update test_filepointer to be less insane. https://reviewboard.mozilla.org/r/230064/#review236234

Attachment #8961271 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 49

•

8 years ago

mozreview-review

Comment on attachment 8961272 [details] Bug 1447903: Part 8b - Update test_filepointer to use bootstrapped extensions. https://reviewboard.mozilla.org/r/230066/#review236236 I think a bunch of calls to promiseRestartManager() could probably also be removed now but its not necessary.

Attachment #8961272 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 50

•

8 years ago

mozreview-review

Comment on attachment 8961273 [details] Bug 1447903: Part 8c - Update test_proxies to use bootstrapped extensions. https://reviewboard.mozilla.org/r/230068/#review236238

Attachment #8961273 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 51

•

8 years ago

mozreview-review

Comment on attachment 8961274 [details] Bug 1447903: Part 9a - Refactor test_AddonRepository*.js to be less insane. https://reviewboard.mozilla.org/r/230070/#review236242

Attachment #8961274 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 52

•

8 years ago

mozreview-review

Comment on attachment 8961275 [details] Bug 1447903: Part 9b - Update test_AddonRepository*.js to use bootstrapped extensions. https://reviewboard.mozilla.org/r/230072/#review236244

Attachment #8961275 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 53

•

8 years ago

mozreview-review

Comment on attachment 8961276 [details] Bug 1447903: Part 10a - Refactor test_cacheflush.js to not be insane. https://reviewboard.mozilla.org/r/230074/#review236246

Attachment #8961276 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 54

•

8 years ago

mozreview-review

Comment on attachment 8961277 [details] Bug 1447903: Part 10b - Update test_cacheflush.js to only test restartless add-ons. https://reviewboard.mozilla.org/r/230076/#review236248

Attachment #8961277 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 55

•

8 years ago

mozreview-review

Comment on attachment 8961278 [details] Bug 1447903: Part 11a - Refactor test_strictcompatibility.js to be less insane. https://reviewboard.mozilla.org/r/230078/#review236250 ::: toolkit/mozapps/extensions/test/xpcshell/test_strictcompatibility.js:25 (Diff revision 1) > - }] > + }] > -}; > + }, > + expected: { > + strictCompatibility: false, > + }, > + compatible: [true, true, true, true, true, true], Please add a comment (perhaps above line 9) explaining this so a reader doesn't need to go down to the code and then come back up here to make sense of it

Attachment #8961278 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 56

•

8 years ago

mozreview-review

Comment on attachment 8961279 [details] Bug 1447903: Part 11b - Update test_strictcompatibility.js to use bootstrapped extensions. https://reviewboard.mozilla.org/r/230080/#review236252 I think the whole restart process isn't necessary anymore but that can wait for another day.

Attachment #8961279 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 57

•

8 years ago

mozreview-review

Comment on attachment 8961280 [details] Bug 1447903: Part 11c - Fold test_checkcompatibility.js into test_strictcompatibility and update to use bootstrapped extensions. https://reviewboard.mozilla.org/r/230082/#review236254 ::: toolkit/mozapps/extensions/test/xpcshell/test_strictcompatibility.js:271 (Diff revision 1) > + }, > + compatible: false, > + canOverride: true, > + }, > + > + "cc-addon3@tests.mozilla.org": { do we need both this and cc-addon2? ::: toolkit/mozapps/extensions/test/xpcshell/test_strictcompatibility.js:307 (Diff revision 1) > + compatible: true, > + }, > + > + "cc-addon5@tests.mozilla.org": { > + "install.rdf": { > + // Always compatible and enabled indentation

Attachment #8961280 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 58

•

8 years ago

mozreview-review

Comment on attachment 8961281 [details] Bug 1447903: Part 12 - Update test_update.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230084/#review236256 ::: commit-message-e3468:1 (Diff revision 1) > +Bug 1447903: Part 12 - Update test_update.js to use only bootstrapped extensions. r?aswan update -> upgrade

Attachment #8961281 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 59

•

8 years ago

mozreview-review

Comment on attachment 8961282 [details] Bug 1447903: Part 13 - Update test_syncGUID.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230086/#review236260

Attachment #8961282 - Flags: review?(aswan) → review+

Kris Maglione [:kmag]

Assignee

Comment 60

•

8 years ago

mozreview-review-reply

Comment on attachment 8961268 [details] Bug 1447903: Part 6b - Roll test_targetPlatforms.js into test_manifest and make non-insane. https://reviewboard.mozilla.org/r/230058/#review236222 So many places. > how about just false? likewise below Heh. It was an artifact of the macro rewriting. I forgot to clean it up afterwards.

Kris Maglione [:kmag]

Assignee

Comment 61

•

8 years ago

mozreview-review-reply

Comment on attachment 8961270 [details] Bug 1447903: Part 7 - Update simpler tests to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230062/#review236228 > what does this have to do with boostrapped-ness? We only notify for extensions that require a restart to disable. I.e., this never happens for bootstrapped extensions. > can we just remove this test (and the corresponding code in XPIProvider)? Yes.

Andrew Swan [:aswan]

Comment 62

•

8 years ago

mozreview-review

Comment on attachment 8961283 [details] Bug 1447903: Part 14 - Update test_bug655254.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230088/#review236266

Attachment #8961283 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 63

•

8 years ago

mozreview-review

Comment on attachment 8961284 [details] Bug 1447903: Part 15 - Remove over-kill bug470377 tests. https://reviewboard.mozilla.org/r/230090/#review236270

Attachment #8961284 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 64

•

8 years ago

mozreview-review

Comment on attachment 8961285 [details] Bug 1447903: Part 16 - Update test_signed_verify.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230092/#review236272

Attachment #8961285 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 65

•

8 years ago

mozreview-review

Comment on attachment 8961286 [details] Bug 1447903: Part 17 - Update test_bug335238.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230094/#review236274

Attachment #8961286 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 66

•

8 years ago

mozreview-review

Comment on attachment 8961287 [details] Bug 1447903: Part 18a - Update test_bug397778.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230096/#review236276

Attachment #8961287 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 67

•

8 years ago

mozreview-review

Comment on attachment 8961288 [details] Bug 1447903: Part 18b - Fold test_bug425657 into test_bug397778.js. https://reviewboard.mozilla.org/r/230098/#review236278

Attachment #8961288 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 68

•

8 years ago

mozreview-review

Comment on attachment 8961289 [details] Bug 1447903: Part 19a - Refactor test_blocklistchange.js to be less insane. https://reviewboard.mozilla.org/r/230100/#review236280

Attachment #8961289 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 69

•

8 years ago

mozreview-review

Comment on attachment 8961290 [details] Bug 1447903: Part 19b - Update test_blocklistchange.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230102/#review236282

Attachment #8961290 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 70

•

8 years ago

mozreview-review

Comment on attachment 8961291 [details] Bug 1447903: Part 21 - Update test_bug455906.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230104/#review236290

Attachment #8961291 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 71

•

8 years ago

mozreview-review

Comment on attachment 8961557 [details] Bug 1447903: Part 22 - Refactor test_dictionary.js to be less insane. https://reviewboard.mozilla.org/r/230378/#review236292 ::: toolkit/mozapps/extensions/test/xpcshell/test_dictionary.js:111 (Diff revision 2) > - do_test_pending(); > - > + // Dictionaries are only supported unpacked. > + AddonTestUtils.testUnpacked = true; how about we move this test to `xpcshell-unpack.ini` and assert that testUnpacked is true here ::: toolkit/mozapps/extensions/test/xpcshell/test_dictionary.js:372 (Diff revision 2) > - // spin the event loop to let the addon finish starting > + // spin the event loop to let the addon finish starting > - executeSoon(function check_installed_dictionary() { > + await new Promise(executeSoon); Is this needed?

Attachment #8961557 - Flags: review?(aswan) → review+

Comment hidden (mozreview-request)

Kris Maglione [:kmag]

Assignee

Updated

•

8 years ago

Attachment #8961637 - Attachment is obsolete: true

Attachment #8961637 - Flags: review?(aswan)

Code Review Bot [:reviewbot]

Comment 106

•

8 years ago

mozreview-review

Comment on attachment 8961265 [details] Bug 1447903: Part 4 - Remove xpcshell tests which only apply to restart-required extensions. https://reviewboard.mozilla.org/r/230052/#review236308 Code analysis found 5 defects in this patch: - 5 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:245 (Diff revision 2) > - Assert.ok(a1.syncGUID.length >= 9); > - Assert.equal(a1.syncGUID, installSyncGUID); > - Assert.equal(a1.type, "extension"); > - Assert.equal(a1.version, "1.0"); > - Assert.equal(a1.name, "Test 1"); > - Assert.ok(isExtensionInAddonsList(profileDir, a1.id)); > + ok(a1.syncGUID.length >= 9); > + equal(a1.syncGUID, installSyncGUID); > + equal(a1.type, "extension"); > + equal(a1.version, "1.0"); > + equal(a1.name, "Test 1"); > + ok(isExtensionInBootstrappedList(profileDir, a1.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:359 (Diff revision 2) > - Assert.notEqual(a2, null); > - Assert.notEqual(a2.syncGUID, null); > - Assert.equal(a2.type, "extension"); > - Assert.equal(a2.version, "2.0"); > - Assert.equal(a2.name, "Real Test 2"); > - Assert.ok(isExtensionInAddonsList(profileDir, a2.id)); > + notEqual(a2, null); > + notEqual(a2.syncGUID, null); > + equal(a2.type, "extension"); > + equal(a2.version, "2.0"); > + equal(a2.name, "Real Test 2"); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:443 (Diff revision 2) > - Assert.notEqual(olda2, null); > - Assert.ok(hasFlag(olda2.pendingOperations, AddonManager.PENDING_UPGRADE)); > - > - AddonManager.getInstallsByTypes(null, callback_soon(function(installs) { > - Assert.equal(installs.length, 1); > - Assert.equal(installs[0].addon, olda2.pendingUpgrade); > + notEqual(a2, null); > + equal(a2.type, "extension"); > + equal(a2.version, "3.0"); > + equal(a2.name, "Real Test 3"); > + ok(a2.isActive); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:525 (Diff revision 2) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:566 (Diff revision 2) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef]

Comment hidden (mozreview-request)

Code Review Bot [:reviewbot]

Comment 140

•

8 years ago

mozreview-review

Comment on attachment 8961265 [details] Bug 1447903: Part 4 - Remove xpcshell tests which only apply to restart-required extensions. https://reviewboard.mozilla.org/r/230052/#review236310 Code analysis found 5 defects in this patch: - 5 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:245 (Diff revision 3) > - Assert.ok(a1.syncGUID.length >= 9); > - Assert.equal(a1.syncGUID, installSyncGUID); > - Assert.equal(a1.type, "extension"); > - Assert.equal(a1.version, "1.0"); > - Assert.equal(a1.name, "Test 1"); > - Assert.ok(isExtensionInAddonsList(profileDir, a1.id)); > + ok(a1.syncGUID.length >= 9); > + equal(a1.syncGUID, installSyncGUID); > + equal(a1.type, "extension"); > + equal(a1.version, "1.0"); > + equal(a1.name, "Test 1"); > + ok(isExtensionInBootstrappedList(profileDir, a1.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:359 (Diff revision 3) > - Assert.notEqual(a2, null); > - Assert.notEqual(a2.syncGUID, null); > - Assert.equal(a2.type, "extension"); > - Assert.equal(a2.version, "2.0"); > - Assert.equal(a2.name, "Real Test 2"); > - Assert.ok(isExtensionInAddonsList(profileDir, a2.id)); > + notEqual(a2, null); > + notEqual(a2.syncGUID, null); > + equal(a2.type, "extension"); > + equal(a2.version, "2.0"); > + equal(a2.name, "Real Test 2"); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:443 (Diff revision 3) > - Assert.notEqual(olda2, null); > - Assert.ok(hasFlag(olda2.pendingOperations, AddonManager.PENDING_UPGRADE)); > - > - AddonManager.getInstallsByTypes(null, callback_soon(function(installs) { > - Assert.equal(installs.length, 1); > - Assert.equal(installs[0].addon, olda2.pendingUpgrade); > + notEqual(a2, null); > + equal(a2.type, "extension"); > + equal(a2.version, "3.0"); > + equal(a2.name, "Real Test 3"); > + ok(a2.isActive); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:525 (Diff revision 3) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:566 (Diff revision 3) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef]

Andrew Swan [:aswan]

Comment 141

•

8 years ago

mozreview-review

Comment on attachment 8961260 [details] Bug 1447903: Part 3a - Refactor test_corrupt.js to not be insane. https://reviewboard.mozilla.org/r/230042/#review236362 nice, thank you

Attachment #8961260 - Flags: review?(aswan) → review+

Comment hidden (mozreview-request)

Code Review Bot [:reviewbot]

Comment 175

•

8 years ago

mozreview-review

Comment on attachment 8961265 [details] Bug 1447903: Part 4 - Remove xpcshell tests which only apply to restart-required extensions. https://reviewboard.mozilla.org/r/230052/#review236376 Code analysis found 5 defects in this patch: - 5 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:240 (Diff revision 4) > - Assert.ok(a1.syncGUID.length >= 9); > - Assert.equal(a1.syncGUID, installSyncGUID); > - Assert.equal(a1.type, "extension"); > - Assert.equal(a1.version, "1.0"); > - Assert.equal(a1.name, "Test 1"); > - Assert.ok(isExtensionInAddonsList(profileDir, a1.id)); > + ok(a1.syncGUID.length >= 9); > + equal(a1.syncGUID, installSyncGUID); > + equal(a1.type, "extension"); > + equal(a1.version, "1.0"); > + equal(a1.name, "Test 1"); > + ok(isExtensionInBootstrappedList(profileDir, a1.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:354 (Diff revision 4) > - Assert.notEqual(a2, null); > - Assert.notEqual(a2.syncGUID, null); > - Assert.equal(a2.type, "extension"); > - Assert.equal(a2.version, "2.0"); > - Assert.equal(a2.name, "Real Test 2"); > - Assert.ok(isExtensionInAddonsList(profileDir, a2.id)); > + notEqual(a2, null); > + notEqual(a2.syncGUID, null); > + equal(a2.type, "extension"); > + equal(a2.version, "2.0"); > + equal(a2.name, "Real Test 2"); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:438 (Diff revision 4) > - Assert.notEqual(olda2, null); > - Assert.ok(hasFlag(olda2.pendingOperations, AddonManager.PENDING_UPGRADE)); > - > - AddonManager.getInstallsByTypes(null, callback_soon(function(installs) { > - Assert.equal(installs.length, 1); > - Assert.equal(installs[0].addon, olda2.pendingUpgrade); > + notEqual(a2, null); > + equal(a2.type, "extension"); > + equal(a2.version, "3.0"); > + equal(a2.name, "Real Test 3"); > + ok(a2.isActive); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:520 (Diff revision 4) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:561 (Diff revision 4) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef]

Comment hidden (mozreview-request)

Code Review Bot [:reviewbot]

Comment 207

•

8 years ago

mozreview-review

Comment on attachment 8961265 [details] Bug 1447903: Part 4 - Remove xpcshell tests which only apply to restart-required extensions. https://reviewboard.mozilla.org/r/230052/#review236412 Code analysis found 5 defects in this patch: - 5 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:240 (Diff revision 5) > - Assert.ok(a1.syncGUID.length >= 9); > - Assert.equal(a1.syncGUID, installSyncGUID); > - Assert.equal(a1.type, "extension"); > - Assert.equal(a1.version, "1.0"); > - Assert.equal(a1.name, "Test 1"); > - Assert.ok(isExtensionInAddonsList(profileDir, a1.id)); > + ok(a1.syncGUID.length >= 9); > + equal(a1.syncGUID, installSyncGUID); > + equal(a1.type, "extension"); > + equal(a1.version, "1.0"); > + equal(a1.name, "Test 1"); > + ok(isExtensionInBootstrappedList(profileDir, a1.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:354 (Diff revision 5) > - Assert.notEqual(a2, null); > - Assert.notEqual(a2.syncGUID, null); > - Assert.equal(a2.type, "extension"); > - Assert.equal(a2.version, "2.0"); > - Assert.equal(a2.name, "Real Test 2"); > - Assert.ok(isExtensionInAddonsList(profileDir, a2.id)); > + notEqual(a2, null); > + notEqual(a2.syncGUID, null); > + equal(a2.type, "extension"); > + equal(a2.version, "2.0"); > + equal(a2.name, "Real Test 2"); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:438 (Diff revision 5) > - Assert.notEqual(olda2, null); > - Assert.ok(hasFlag(olda2.pendingOperations, AddonManager.PENDING_UPGRADE)); > - > - AddonManager.getInstallsByTypes(null, callback_soon(function(installs) { > - Assert.equal(installs.length, 1); > - Assert.equal(installs[0].addon, olda2.pendingUpgrade); > + notEqual(a2, null); > + equal(a2.type, "extension"); > + equal(a2.version, "3.0"); > + equal(a2.name, "Real Test 3"); > + ok(a2.isActive); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:520 (Diff revision 5) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:561 (Diff revision 5) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef]

Andrew Swan [:aswan]

Comment 208

•

8 years ago

mozreview-review

Comment on attachment 8961262 [details] Bug 1447903: Part 3c - Refactor test_badschema.js to not be insane. https://reviewboard.mozilla.org/r/230046/#review236410

Attachment #8961262 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 209

•

8 years ago

mozreview-review

Comment on attachment 8961263 [details] Bug 1447903: Part 3d - Update test_corrupt.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230048/#review236426

Attachment #8961263 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 210

•

8 years ago

mozreview-review

Comment on attachment 8961264 [details] Bug 1447903: Part 3e - Update test_badschema.js to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230050/#review236428

Attachment #8961264 - Flags: review?(aswan) → review+

Kris Maglione [:kmag]

Assignee

Updated

•

8 years ago

Depends on: 1446686

Comment hidden (mozreview-request)

Code Review Bot [:reviewbot]

Comment 249

•

8 years ago

mozreview-review

Comment on attachment 8961265 [details] Bug 1447903: Part 4 - Remove xpcshell tests which only apply to restart-required extensions. https://reviewboard.mozilla.org/r/230052/#review236466 Code analysis found 5 defects in this patch: - 5 defects found by mozlint You can run this analysis locally with: - `./mach lint path/to/file` (JS/Python) If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:240 (Diff revision 6) > - Assert.ok(a1.syncGUID.length >= 9); > - Assert.equal(a1.syncGUID, installSyncGUID); > - Assert.equal(a1.type, "extension"); > - Assert.equal(a1.version, "1.0"); > - Assert.equal(a1.name, "Test 1"); > - Assert.ok(isExtensionInAddonsList(profileDir, a1.id)); > + ok(a1.syncGUID.length >= 9); > + equal(a1.syncGUID, installSyncGUID); > + equal(a1.type, "extension"); > + equal(a1.version, "1.0"); > + equal(a1.name, "Test 1"); > + ok(isExtensionInBootstrappedList(profileDir, a1.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:354 (Diff revision 6) > - Assert.notEqual(a2, null); > - Assert.notEqual(a2.syncGUID, null); > - Assert.equal(a2.type, "extension"); > - Assert.equal(a2.version, "2.0"); > - Assert.equal(a2.name, "Real Test 2"); > - Assert.ok(isExtensionInAddonsList(profileDir, a2.id)); > + notEqual(a2, null); > + notEqual(a2.syncGUID, null); > + equal(a2.type, "extension"); > + equal(a2.version, "2.0"); > + equal(a2.name, "Real Test 2"); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:438 (Diff revision 6) > - Assert.notEqual(olda2, null); > - Assert.ok(hasFlag(olda2.pendingOperations, AddonManager.PENDING_UPGRADE)); > - > - AddonManager.getInstallsByTypes(null, callback_soon(function(installs) { > - Assert.equal(installs.length, 1); > - Assert.equal(installs[0].addon, olda2.pendingUpgrade); > + notEqual(a2, null); > + equal(a2.type, "extension"); > + equal(a2.version, "3.0"); > + equal(a2.name, "Real Test 3"); > + ok(a2.isActive); > + ok(isExtensionInBootstrappedList(profileDir, a2.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:520 (Diff revision 6) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef] ::: toolkit/mozapps/extensions/test/xpcshell/test_install.js:561 (Diff revision 6) > - Assert.equal(a3.type, "extension"); > - Assert.equal(a3.version, "1.0"); > - Assert.equal(a3.name, "Real Test 4"); > - Assert.ok(a3.isActive); > - Assert.ok(!a3.appDisabled); > - Assert.ok(isExtensionInAddonsList(profileDir, a3.id)); > + equal(a3.type, "extension"); > + equal(a3.version, "1.0"); > + equal(a3.name, "Real Test 4"); > + ok(a3.isActive); > + ok(!a3.appDisabled); > + ok(isExtensionInBootstrappedList(profileDir, a3.id)); Error: 'isextensioninbootstrappedlist' is not defined. [eslint: no-undef]

Andrew Swan [:aswan]

Comment 250

•

8 years ago

mozreview-review

Comment on attachment 8961270 [details] Bug 1447903: Part 7 - Update simpler tests to use only bootstrapped extensions. https://reviewboard.mozilla.org/r/230062/#review236652

Attachment #8961270 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 251

•

8 years ago

mozreview-review

Comment on attachment 8962218 [details] Bug 1447903: Part 0 - Add getAddons() and checkAddon() helpers to head_addons.js. https://reviewboard.mozilla.org/r/231046/#review236750

Attachment #8962218 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 252

•

8 years ago

mozreview-review

Comment on attachment 8962219 [details] Bug 1447903: Part 20a - Refactor test_update.js to be less insane. https://reviewboard.mozilla.org/r/231048/#review236754 ::: toolkit/mozapps/extensions/internal/AddonTestUtils.jsm:1260 (Diff revision 1) > > promiseCompleteAllInstalls(installs) { > return Promise.all(Array.from(installs, this.promiseCompleteInstall)); > }, > > + updateReason: AddonManager.UPDATE_WHEN_PERIODIC_UPDATE, add a brief documentation comment (ie this is so tests can set the default reason for findUpdates without explicitly passing reason each time) ::: toolkit/mozapps/extensions/internal/AddonTestUtils.jsm:1271 (Diff revision 1) > * > * @param {object} addon The add-on to find updates for. > * @param {integer} reason The type of update to find. > * @return {Promise<object>} an object containing information about the update. > */ > - promiseFindAddonUpdates(addon, reason = AddonManager.UPDATE_WHEN_PERIODIC_UPDATE) { > + promiseFindAddonUpdates(addon, reason = AddonTestUtils.updateReason, ...args) { add `args` to the jsdoc above ::: toolkit/mozapps/extensions/test/xpcshell/test_update.js:823 (Diff revision 1) > > -check_test_14 = () => { > - restartManager(); > - AddonManager.getAddonsByIDs(["addon1@tests.mozilla.org", > - "addon8@tests.mozilla.org"], function([a1, a8]) { > - Assert.notEqual(a1, null); > + await promiseRestartManager(); > + > + let a1; > + [a1, a8] = await AddonManager.getAddonsByIDs(["addon1@tests.mozilla.org", > + "addon8@tests.mozilla.org"]); indentation

Attachment #8962219 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 253

•

8 years ago

mozreview-review

Comment on attachment 8962220 [details] Bug 1447903: Part 20b - Update test_update.js to use only bootstrapped add-ons. https://reviewboard.mozilla.org/r/231050/#review236762

Attachment #8962220 - Flags: review?(aswan) → review+

Andrew Swan [:aswan]

Comment 254

•

8 years ago

mozreview-review

Comment on attachment 8962220 [details] Bug 1447903: Part 20b - Update test_update.js to use only bootstrapped add-ons. https://reviewboard.mozilla.org/r/231050/#review236764 ::: testing/xpcshell/head.js:789 (Diff revision 1) > } > > function do_report_result(passed, text, stack, todo) { > // Match names like head.js, head_foo.js, and foo_head.js, but not > // test_headache.js > - while (/(\/head(_.+)?|head)\.js$/.test(stack.filename) && stack.caller) { > + while (false && /(\/head(_.+)?|head)\.js$/.test(stack.filename) && stack.caller) { remove this before landing of course

Kris Maglione [:kmag]

Assignee

Comment 255

•

8 years ago

Bogdan Tara[:bogdan_tara | bogdant]

Comment 256

•

8 years ago

bugherder

Status: NEW → RESOLVED

Closed: 8 years ago

status-firefox61: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla61

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

8 years ago

Depends on: 1449173

marius.santa

Updated

•

8 years ago

Flags: qe-verify-

Rob Wu [:robwu]

Updated

•

5 years ago

Bug 1447903: Part 1 - Remove locked DB tests. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 2 - Remove strictcompat variants of tests. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 3a - Refactor test_corrupt.js to not be insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 3b - Remove test_bug559800.js, which overlaps with test_corrupt.js. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 3c - Refactor test_badschema.js to not be insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 3d - Update test_corrupt.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 3e - Update test_badschema.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 4 - Remove xpcshell tests which only apply to restart-required extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 5 - Update test_startup to use bootstrapped extensions (but still be insane). 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 6a - Refactor test_manifest.js to not be insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 6b - Roll test_targetPlatforms.js into test_manifest and make non-insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 6c - Update test_manifest.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 7 - Update simpler tests to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 8a - Update test_filepointer to be less insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 8b - Update test_filepointer to use bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 8c - Update test_proxies to use bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 9a - Refactor test_AddonRepository*.js to be less insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 9b - Update test_AddonRepository*.js to use bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 10a - Refactor test_cacheflush.js to not be insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 10b - Update test_cacheflush.js to only test restartless add-ons. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 11a - Refactor test_strictcompatibility.js to be less insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 11b - Update test_strictcompatibility.js to use bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 11c - Fold test_checkcompatibility.js into test_strictcompatibility and update to use bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 12 - Update test_update.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 13 - Update test_syncGUID.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 14 - Update test_bug655254.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 15 - Remove over-kill bug470377 tests. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 16 - Update test_signed_verify.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 17 - Update test_bug335238.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 18a - Update test_bug397778.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 18b - Fold test_bug425657 into test_bug397778.js. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 19a - Refactor test_blocklistchange.js to be less insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 19b - Update test_blocklistchange.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 21 - Update test_bug455906.js to use only bootstrapped extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 22 - Refactor test_dictionary.js to be less insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 22 - Update test_install.js to use restartless extensions. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request		Details
Bug 1447903: Part 0 - Add getAddons() and checkAddon() helpers to head_addons.js. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 20a - Refactor test_update.js to be less insane. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details
Bug 1447903: Part 20b - Update test_update.js to use only bootstrapped add-ons. 8 years ago Kris Maglione [:kmag] 59 bytes, text/x-review-board-request	aswan : review+	Details