1704174 - Figure out what to do with menulist reftest failure when Proton is enabled

Status: RESOLVED DUPLICATE of bug 1704841

(Toolkit :: UI Widgets, task)

Description

[Mike Conley (:mconley) (:⚙️)]

When turning on Proton context menus, we hit the reftest failure in bug 1704163 for menulist-shrinkwrap-2-ref.xhtml.

Since this is a XUL reftest, and it seems pretty obscure (text cropping for short menulists when the parent node has align="start"), I made the judgement call to just disable Proton for that test, and file this follow-up bug for the investigation.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: live_backing.log

Comment 2

[Mike Conley (:mconley) (:⚙️)]

The original reftest failure log can be viewed in the reftest analyzer here: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aCODfTC9QYGMFnc0kKupiQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

That file will eventually be culled from the treeherder artifacts, so I've uploaded it here to the bug. Whoever ends up working on this can download the file, and attach it to the reftest analyzer here:

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml

Comment 3

[Mike Conley (:mconley) (:⚙️)]

According to emilio:

The relevant bug / code is bug 623922, and if that is getting cropped, it seems like a bug in the menupopup sizing code touched in that bug.
I think to fix it you need to add the padding to the menupopup, that's the assumption that the xul code is doing: https://searchfox.org/mozilla-central/rev/3ae6f9e4444f3fbf61034317540d36f621117600/layout/xul/nsMenuFrame.cpp#1034