1704361 - Ensure calling baseFrontClassDestroy before custom Front::destroy

Status: NEW

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

The destroy method of the base Front class is often overloaded. Sometimes it's even overloaded with an async method:

destroy: async function() {
  await someAsyncMethod();
  super.destroy();
}

With this kind of pattern, the parent's destroy is not called synchronously. There are some critical bits in Front::destroy that should run as soon as possible however. They have been extracted to a baseFrontClassDestroy which can safely be called early.

However we are still randomly patching the codebase to call it whenever a problem arises, eg https://phabricator.services.mozilla.com/D108792

      targetFront.baseFrontClassDestroy();
      targetFront.destroy();

This kind of code can be hard to understand as it requires some knowledge about typical destroy issues. It would be nice if this was handled on the framework level.

Comment 1

[Julian Descottes [:jdescottes]]

https://hg.mozilla.org/try/rev/6815be6e7e32b79ae3dc5f69562a0b16c59fdf10

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1704361 - [devtools] Ensure calling baseFrontClassDestroy before custom destroy