1694651 - Support running devtools with bfcache navigation in parent

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Bug 1689601 will introduce a new behavior when a bfcache navigation occurs and fission is enabled.
A new DocShell will be spawn in the same process, which will break the current code supporting bfcache navigation.
Today bfcache navigation is handled by listening to pageshow and pagehide on the chromeeventhandler.
pageshow and pagehide are still firing with the new setup, but on two distinct docshells. We are then missing the pageshow event on the navigated to docshell.

In order to support this new behavior, we would need to listen to pageshow and pagehide from the DevTools's JSWindowActor, and fire a new top level target on pageshow.
But for now, top level targets are only created by the frontend, whereas here, it should be created by the backend. We have to depend on bug 1644397 in order to support that.

Once bug 1644397 lands, it should be quite easy to support the new bfcache navigations.

Comment 1

[Alexandre Poirot [:ochameau]]

Also once this bug lands, we might be able to renable tests that were disabled in bug 1665165.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1694651 - Destroy targets from TargetList.onTargetDestroyed.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1694651 - [devtools] Support running DevTools with BFCache in parent navigation.

BFCache in parent navigation ends up spawning a new DocShell in the same process.
The existing BrowsingContextTargetActor no longer receive the pageshow event,
because it fires on a new, distinct DocShell.
We have to listen for these two events on the JSWindowActor and spawn new target actors
when such navigation happens.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1694651 - Destroy target from TargetList.onTargetDestroyed and get rid of tabDetached

Comment 5

[Alexandre Poirot [:ochameau]]

I'll have to rebase the target destruction patch on top of bug 1694906 as it introduces a destructor-destroyed event, which I'm depending on.

Comment 6

[Alexandre Poirot [:ochameau]]

And I'll try to fix a few things around descriptor/target destroy in bug 1695929 first.

Comment 7

[Phabricator Automation]

Comment on attachment 9206184 [details]
Bug 1694651 - Destroy target from TargetList.onTargetDestroyed and get rid of tabDetached

Revision D106835 was moved to bug 1631451. Setting attachment 9206184 [details] to obsolete.

Comment 8

[Neha Kochar [:neha]]

BFCache with Fission is targeting M7a.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1694651 - [devtools] Immediately destroy the target front when receiving target-destroyed-form.

TargetFrontMixin may try to call detach method which won't work in some cases.
At least for bfcache navigations. The target actor will already be destroyed.
detach will stay pending and the target front will never be fully destroyed
as we only call Front.destroy after detach completed.

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1694651 - [devtools] Fix debugger when doing bfcache navigations in parent.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/350aea656f79
[devtools] Support running DevTools with BFCache in parent navigation. r=jdescottes,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/d8c17c24ef62
[devtools] Immediately destroy the target front when receiving target-destroyed-form. r=jdescottes,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/80de12aca743
[devtools] Fix debugger when doing bfcache navigations in parent. r=jdescottes

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/350aea656f79
https://hg.mozilla.org/mozilla-central/rev/d8c17c24ef62
https://hg.mozilla.org/mozilla-central/rev/80de12aca743