1704572 - Tweak various tests for native context menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

This bug is for patches to various tests to make them work better with native context menus.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1704572 - Fix some viewsource tests to work with native context menus. r=Gijs

Depends on D111680

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1704572 - Use openMenu(true) instead of openPopup() for opening the 'this frame' submenu in browser/base/content/test/contextMenu/browser_contextmenu_iframe.js. r=Gijs

openMenu(true) works on both native and non-native context menus. openPopup() does not work on native context menus.

Depends on D111681

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1704572 - Correctly wait for popup state changes in browser/components/places/tests/browser/browser_check_correct_controllers.js. r=Gijs

Depends on D111682

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1704572 - Use BrowserTestUtils.is_visible rather than checking the bounding client rect in browser_contextmenu_linkopen.js. r=Gijs

Depends on D111683

Comment 5

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3b33f7340db0b1faee4369bf182c8037d531eaea

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da0f99d5b3e4
Fix some viewsource tests to work with native context menus. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/342d46870ead
Use openMenu(true) instead of openPopup() for opening the 'this frame' submenu in browser/base/content/test/contextMenu/browser_contextmenu_iframe.js. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/d9b3cac48bd8
Correctly wait for popup state changes in browser/components/places/tests/browser/browser_check_correct_controllers.js. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/413247fce859
Use BrowserTestUtils.is_visible rather than checking the bounding client rect in browser_contextmenu_linkopen.js. r=Gijs

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/da0f99d5b3e4
https://hg.mozilla.org/mozilla-central/rev/342d46870ead
https://hg.mozilla.org/mozilla-central/rev/d9b3cac48bd8
https://hg.mozilla.org/mozilla-central/rev/413247fce859