Make devtools context menu tests work with macOS native context menus
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: bradwerth, Assigned: bradwerth)
References
Details
(Whiteboard: [proton-uplift])
Attachments
(4 files, 2 obsolete files)
Bug 1704628 Part 2: Make a breakpoint context menu test await the correct number of dispatch events.
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Bug 1704572 will turn on native context menus for macOS. Many devtools tests that use context menus fail with that change. This bug will track efforts to make those tests pass.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Marking as leave-open as I expect to be landing patches while adding more patches.
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D111948
Assignee | ||
Comment 5•3 years ago
|
||
Depends on D112118
Updated•3 years ago
|
Updated•3 years ago
|
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c8093ead9bf2 Part 1: Make selectContextMenuItem use .activateItem() semantics. r=ochameau https://hg.mozilla.org/integration/autoland/rev/5846eb066549 Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau https://hg.mozilla.org/integration/autoland/rev/4fabf90e7df1 Part 3: Make test browser_menu_api.js use activateItem semantics. r=mac-reviewers,mstange
Comment 7•3 years ago
|
||
Backed outfor causing failure at browser_menu_api.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/1e2388345dc86de1d681e893ec9c215dce9735fa
Failure log: https://treeherder.mozilla.org/logviewer?job_id=336674455&repo=autoland&lineNumber=3479
Updated•3 years ago
|
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fea280db91be Part 1: Make selectContextMenuItem use .activateItem() semantics. r=ochameau https://hg.mozilla.org/integration/autoland/rev/e14dcb9ef407 Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau
Updated•3 years ago
|
Comment 9•3 years ago
•
|
||
Backed out for causing failures e.g. browser_dbg-blackbox-all.js
backout: https://hg.mozilla.org/integration/autoland/rev/c35cca23a6ea6f0879af36a99507da37c5d8cdb4
failure logs:
[task 2021-04-15T21:35:46.336Z] 21:35:46 INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js | a new breakpoint was created -
[task 2021-04-15T21:35:46.336Z] 21:35:46 INFO - Expands the whole source tree.
[task 2021-04-15T21:35:46.337Z] 21:35:46 INFO - Blackbox files in this directory.
[task 2021-04-15T21:35:46.337Z] 21:35:46 INFO - Buffered messages finished
[task 2021-04-15T21:35:46.340Z] 21:35:46 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:707 - Error: Failed waitFor():
[task 2021-04-15T21:35:46.340Z] 21:35:46 INFO - Failed condition: () => findContextMenu(dbg, selector)
[task 2021-04-15T21:35:46.340Z] 21:35:46 INFO -
[task 2021-04-15T21:35:46.340Z] 21:35:46 INFO - Stack trace:
[task 2021-04-15T21:35:46.341Z] 21:35:46 INFO - waitFor@chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:707:11
[task 2021-04-15T21:35:46.341Z] 21:35:46 INFO - asyncwaitForContextMenu@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/helpers.js:1569:9
[task 2021-04-15T21:35:46.341Z] 21:35:46 INFO - assertContextMenuLabel@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/helpers.js:1579:22
[task 2021-04-15T21:35:46.341Z] 21:35:46 INFO - @chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js:43:9
[task 2021-04-15T21:35:46.342Z] 21:35:46 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1089:34
[task 2021-04-15T21:35:46.342Z] 21:35:46 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1129:11
[task 2021-04-15T21:35:46.342Z] 21:35:46 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:949:14
[task 2021-04-15T21:35:46.342Z] 21:35:46 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1037:23
[task 2021-04-15T21:35:46.343Z] 21:35:46 INFO - Leaving test bound
[task 2021-04-15T21:08:07.385Z] 21:08:07 INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-watchpoints.js | Frame paused at 19, but expected 19 -
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - Remove the get watchpoint on b
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - Buffered messages finished
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-watchpoints.js | Test timed out -
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - GECKO(1658) | JavaScript error: resource://devtools/server/actors/targets/browsing-context.js, line 102: TypeError: can't access property "browsingContext", parentDocShell is null
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - GECKO(1658) | JavaScript error: resource://devtools/server/actors/highlighters/utils/markup.js, line 141: TypeError: can't access property "document", window is null
[task 2021-04-15T21:08:07.410Z] 21:08:07 INFO - Removing tab.
[task 2021-04-15T21:08:07.411Z] 21:08:07 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2021-04-15T21:08:07.411Z] 21:08:07 INFO - Got event: 'TabClose' on [object XULElement].
[task 2021-04-15T21:08:07.428Z] 21:08:07 INFO - Tab removed and finished closing
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4df249cccd6e Part 1: Make selectContextMenuItem use .activateItem() semantics. r=ochameau https://hg.mozilla.org/integration/autoland/rev/d7c6bae278e0 Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau
Comment 11•3 years ago
|
||
Backed out 2 changesets (bug 1704628) for Devtools failures in devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=337029762&repo=autoland&lineNumber=2933
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=d7c6bae278e02d5810b3a45fb2d287184371de09
Backout:
https://hg.mozilla.org/integration/autoland/rev/6c513e612552be0b37390ce2abbeb448151ec96f
Assignee | ||
Comment 12•3 years ago
|
||
Hmm... I didn't want to make changes to browser_dbg-blackbox-all.js because a better solution is in flight in Bug 1706127. I'll make this bug dependent on that bug.
Updated•3 years ago
|
Comment 13•3 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91e8a2bfe9a0 Part 1: Make test browser_dbg-watchpoints.js work with macOS native context menus. r=ochameau https://hg.mozilla.org/integration/autoland/rev/cb69b22fcc12 Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau
Comment 14•3 years ago
|
||
Backed out 2 changesets (bug 1704628) for Mochitest failures in image/test/mochitest/test_bug496292.html. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=337105259&repo=autoland&lineNumber=15089
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=cb69b22fcc121f56186738d27f819058311a9ca7
Backout:
https://hg.mozilla.org/integration/autoland/rev/6afd14f71f1a1fa1b6ce13364f25d922cd6e15a9
Updated•3 years ago
|
Assignee | ||
Comment 15•3 years ago
|
||
Depends on D112119
Assignee | ||
Comment 16•3 years ago
|
||
This landing is not going well! Trying another try run to gain confidence that the patches are landable: https://treeherder.mozilla.org/#/jobs?repo=try&revision=718bc2a2c68e9f2bf4c0cf852ca0d81bcfabbd16
Assignee | ||
Comment 17•3 years ago
|
||
Depends on D112795
Comment 18•3 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c3a2d5241c4 Part 1: Make test browser_dbg-watchpoints.js work with macOS native context menus. r=ochameau https://hg.mozilla.org/integration/autoland/rev/dea1a02f70c7 Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau https://hg.mozilla.org/integration/autoland/rev/9f54a830d0ce Part 3: Rework part of test browser_menu_api.js on macOS. r=mac-reviewers,mstange https://hg.mozilla.org/integration/autoland/rev/465971c6b4b2 Part 4: Avoid use of ESC to close context menu in browser_toolbox_contentpage_contextmenu.js. r=mac-reviewers,mstange
Comment 19•3 years ago
|
||
bugherder |
Comment 20•3 years ago
|
||
Backed out 4 changesets (Bug 1704628) for causing dt failures in browser_dbg-watchpoints.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/e99e7e2c43c8ae2b91b85cdec5360811ca11cdd0
Push with failures, failure log.
Comment 21•3 years ago
|
||
Backout merged: https://hg.mozilla.org/mozilla-central/rev/e99e7e2c43c8
Assignee | ||
Comment 22•3 years ago
|
||
I'll drop Part 1 and block on Bug 1706483 which has a working solution for browser_dbg-watchpoints.js.
Updated•3 years ago
|
Comment 23•3 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8d4862aa713 Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau https://hg.mozilla.org/integration/autoland/rev/542c2aa5bfd3 Part 3: Rework part of test browser_menu_api.js on macOS. r=mac-reviewers,mstange https://hg.mozilla.org/integration/autoland/rev/9053398b763b Part 4: Avoid use of ESC to close context menu in browser_toolbox_contentpage_contextmenu.js. r=mac-reviewers,mstange https://hg.mozilla.org/integration/autoland/rev/cf81be099de0 Part 5: Avoid use of ESC to close context menu in browser_toolbox_textbox_context_menu.js. r=mac-reviewers,mstange
Comment 24•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Comment 25•3 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/dec816c10fac
https://hg.mozilla.org/releases/mozilla-beta/rev/5a8cc18051f7
https://hg.mozilla.org/releases/mozilla-beta/rev/4ce5856318d7
https://hg.mozilla.org/releases/mozilla-beta/rev/d5c525e27f3f
Updated•3 years ago
|
Updated•2 years ago
|
Description
•