1704628 - Make devtools context menu tests work with macOS native context menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Brad Werth [:bradwerth]]

Bug 1704572 will turn on native context menus for macOS. Many devtools tests that use context menus fail with that change. This bug will track efforts to make those tests pass.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1704628 Part 1: Make test browser_dbg-watchpoints.js work with macOS native context menus.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1704628 Part 2: Make a breakpoint context menu test await the correct number of dispatch events.

Comment 3

[Brad Werth [:bradwerth]]

Marking as leave-open as I expect to be landing patches while adding more patches.

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1704628 Part 3: Make a breakpoint submenu test use openMenu() semantics.

Depends on D111948

Comment 5

[Brad Werth [:bradwerth]]

Attachment: Bug 1704628 Part 3: Rework part of test browser_menu_api.js on macOS.

Depends on D112118

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8093ead9bf2
Part 1: Make selectContextMenuItem use .activateItem() semantics. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/5846eb066549
Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/4fabf90e7df1
Part 3: Make test browser_menu_api.js use activateItem semantics. r=mac-reviewers,mstange

Comment 7

[Atila Butkovits]

Backed outfor causing failure at browser_menu_api.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1e2388345dc86de1d681e893ec9c215dce9735fa

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=IT402QMsTJiIMk0o4X4Quw.0&revision=4fabf90e7df179145603831d4a5c4166040b5868&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-e10s%2Cdt3

Failure log: https://treeherder.mozilla.org/logviewer?job_id=336674455&repo=autoland&lineNumber=3479

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fea280db91be
Part 1: Make selectContextMenuItem use .activateItem() semantics. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/e14dcb9ef407
Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures e.g. browser_dbg-blackbox-all.js

backout: https://hg.mozilla.org/integration/autoland/rev/c35cca23a6ea6f0879af36a99507da37c5d8cdb4

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=e14dcb9ef407141d2fffa216c7a2f1f700418b78&selectedTaskRun=RZ4ESR41R1mt25OWj6zv6Q.0

failure logs:

• TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:707 - Error: Failed waitFor():

[task 2021-04-15T21:35:46.336Z] 21:35:46 INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js | a new breakpoint was created -
[task 2021-04-15T21:35:46.336Z] 21:35:46 INFO - Expands the whole source tree.
[task 2021-04-15T21:35:46.337Z] 21:35:46 INFO - Blackbox files in this directory.
[task 2021-04-15T21:35:46.337Z] 21:35:46 INFO - Buffered messages finished
[task 2021-04-15T21:35:46.340Z] 21:35:46 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:707 - Error: Failed waitFor():
[task 2021-04-15T21:35:46.340Z] 21:35:46 INFO - Failed condition: () => findContextMenu(dbg, selector)
[task 2021-04-15T21:35:46.340Z] 21:35:46 INFO -
[task 2021-04-15T21:35:46.340Z] 21:35:46 INFO - Stack trace:
[task 2021-04-15T21:35:46.341Z] 21:35:46 INFO - waitFor@chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js:707:11
[task 2021-04-15T21:35:46.341Z] 21:35:46 INFO - asyncwaitForContextMenu@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/helpers.js:1569:9
[task 2021-04-15T21:35:46.341Z] 21:35:46 INFO - assertContextMenuLabel@chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/helpers.js:1579:22
[task 2021-04-15T21:35:46.341Z] 21:35:46 INFO - @chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js:43:9
[task 2021-04-15T21:35:46.342Z] 21:35:46 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1089:34
[task 2021-04-15T21:35:46.342Z] 21:35:46 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1129:11
[task 2021-04-15T21:35:46.342Z] 21:35:46 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:949:14
[task 2021-04-15T21:35:46.342Z] 21:35:46 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1037:23
[task 2021-04-15T21:35:46.343Z] 21:35:46 INFO - Leaving test bound

• TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-watchpoints.js | Test timed out -

[task 2021-04-15T21:08:07.385Z] 21:08:07 INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-watchpoints.js | Frame paused at 19, but expected 19 -
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - Remove the get watchpoint on b
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - Buffered messages finished
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-watchpoints.js | Test timed out -
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - GECKO(1658) | JavaScript error: resource://devtools/server/actors/targets/browsing-context.js, line 102: TypeError: can't access property "browsingContext", parentDocShell is null
[task 2021-04-15T21:08:07.386Z] 21:08:07 INFO - GECKO(1658) | JavaScript error: resource://devtools/server/actors/highlighters/utils/markup.js, line 141: TypeError: can't access property "document", window is null
[task 2021-04-15T21:08:07.410Z] 21:08:07 INFO - Removing tab.
[task 2021-04-15T21:08:07.411Z] 21:08:07 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2021-04-15T21:08:07.411Z] 21:08:07 INFO - Got event: 'TabClose' on [object XULElement].
[task 2021-04-15T21:08:07.428Z] 21:08:07 INFO - Tab removed and finished closing

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4df249cccd6e
Part 1: Make selectContextMenuItem use .activateItem() semantics. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/d7c6bae278e0
Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau

Comment 11

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1704628) for Devtools failures in devtools/client/debugger/test/mochitest/browser_dbg-blackbox-all.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=337029762&repo=autoland&lineNumber=2933

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=d7c6bae278e02d5810b3a45fb2d287184371de09

Backout:
https://hg.mozilla.org/integration/autoland/rev/6c513e612552be0b37390ce2abbeb448151ec96f

Comment 12

[Brad Werth [:bradwerth]]

Hmm... I didn't want to make changes to browser_dbg-blackbox-all.js because a better solution is in flight in Bug 1706127. I'll make this bug dependent on that bug.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91e8a2bfe9a0
Part 1: Make test browser_dbg-watchpoints.js work with macOS native context menus. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/cb69b22fcc12
Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau

Comment 14

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1704628) for Mochitest failures in image/test/mochitest/test_bug496292.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=337105259&repo=autoland&lineNumber=15089

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=cb69b22fcc121f56186738d27f819058311a9ca7

Backout:
https://hg.mozilla.org/integration/autoland/rev/6afd14f71f1a1fa1b6ce13364f25d922cd6e15a9

Comment 15

[Brad Werth [:bradwerth]]

Attachment: Bug 1704628 Part 4: Avoid use of ESC to close context menu in browser_toolbox_contentpage_contextmenu.js.

Depends on D112119

Comment 16

[Brad Werth [:bradwerth]]

This landing is not going well! Trying another try run to gain confidence that the patches are landable: https://treeherder.mozilla.org/#/jobs?repo=try&revision=718bc2a2c68e9f2bf4c0cf852ca0d81bcfabbd16

Comment 17

[Brad Werth [:bradwerth]]

Attachment: Bug 1704628 Part 5: Avoid use of ESC to close context menu in browser_toolbox_textbox_context_menu.js.

Depends on D112795

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c3a2d5241c4
Part 1: Make test browser_dbg-watchpoints.js work with macOS native context menus. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/dea1a02f70c7
Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/9f54a830d0ce
Part 3: Rework part of test browser_menu_api.js on macOS. r=mac-reviewers,mstange
https://hg.mozilla.org/integration/autoland/rev/465971c6b4b2
Part 4: Avoid use of ESC to close context menu in browser_toolbox_contentpage_contextmenu.js. r=mac-reviewers,mstange

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7c3a2d5241c4
https://hg.mozilla.org/mozilla-central/rev/dea1a02f70c7
https://hg.mozilla.org/mozilla-central/rev/9f54a830d0ce
https://hg.mozilla.org/mozilla-central/rev/465971c6b4b2

Comment 20

[Alexandru Michis [:malexandru]]

Backed out 4 changesets (Bug 1704628) for causing dt failures in browser_dbg-watchpoints.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/e99e7e2c43c8ae2b91b85cdec5360811ca11cdd0
Push with failures, failure log.

Comment 21

[Iulian Moraru]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/e99e7e2c43c8

Comment 22

[Brad Werth [:bradwerth]]

I'll drop Part 1 and block on Bug 1706483 which has a working solution for browser_dbg-watchpoints.js.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8d4862aa713
Part 2: Make a breakpoint context menu test await the correct number of dispatch events. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/542c2aa5bfd3
Part 3: Rework part of test browser_menu_api.js on macOS. r=mac-reviewers,mstange
https://hg.mozilla.org/integration/autoland/rev/9053398b763b
Part 4: Avoid use of ESC to close context menu in browser_toolbox_contentpage_contextmenu.js. r=mac-reviewers,mstange
https://hg.mozilla.org/integration/autoland/rev/cf81be099de0
Part 5: Avoid use of ESC to close context menu in browser_toolbox_textbox_context_menu.js. r=mac-reviewers,mstange

Comment 24

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b8d4862aa713
https://hg.mozilla.org/mozilla-central/rev/542c2aa5bfd3
https://hg.mozilla.org/mozilla-central/rev/9053398b763b
https://hg.mozilla.org/mozilla-central/rev/cf81be099de0

Comment 25

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/dec816c10fac
https://hg.mozilla.org/releases/mozilla-beta/rev/5a8cc18051f7
https://hg.mozilla.org/releases/mozilla-beta/rev/4ce5856318d7
https://hg.mozilla.org/releases/mozilla-beta/rev/d5c525e27f3f