Closed Bug 1704713 Opened 4 years ago Closed 3 years ago

Intermittent comm/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | xpcshell return code: 0

Categories

(MailNews Core :: Composition, defect, P5)

Tracking

(thunderbird_esr78 unaffected, thunderbird_esr91 wontfix, thunderbird89 affected)

RESOLVED FIXED
90 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird_esr91 --- wontfix
thunderbird89 --- affected

People

(Reporter: intermittent-bug-filer, Assigned: rnons)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fixed by bug 1751461])

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | xpcshell-jsm.ini:comm/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | - nscopy.tmp should not exists - 1 == 0

I was looking at this a bit, not sure it's working correctly. Perhaps that's not it for the failure, but is the not-mailbox case correct (could use come more comments)? Can you check it a bit?
https://searchfox.org/comm-central/rev/3869c8207618a1f123d39c4d2195d3c4eb919bdc/mailnews/compose/src/MessageSend.jsm#865,977

Flags: needinfo?(remotenonsense)

Found this log https://treeherder.mozilla.org/logviewer?job_id=336865672&repo=comm-central&lineNumber=3988

"CONSOLE_MESSAGE: (error) [JavaScript Error: "UnknownError: Could not remove the file at c:\users\task_1618657887\appdata\local\temp\xpc-profile-fyscgp\nscopy.tmp"]

before

TEST-UNEXPECTED-FAIL | xpcshell-jsm.ini:comm/mailnews/compose/test/unit/test_temporaryFilesRemoved.js | - nscopy.tmp should not exists - 1 == 0

That means https://searchfox.org/comm-central/rev/3869c8207618a1f123d39c4d2195d3c4eb919bdc/mailnews/compose/src/MessageSend.jsm#978 fail on Windows, but I don't know why

Flags: needinfo?(remotenonsense)

Maybe windows file locking. Or the file is still open.

From https://treeherder.mozilla.org/logviewer?job_id=337341780&repo=comm-central

[task 2021-04-21T18:27:54.101Z] 18:27:54 INFO - Unexpected exception NotFoundError: Could not stat file(c:\users\task_1619028683\appdata\local\temp\xpc-profile-8nbcbu\permissions.sqlite-journal) because it does not exist

Attached patch 1704713.patch — — Splinter Review
Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED
Attachment #9217619 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9217619 [details] [diff] [review] 1704713.patch Review of attachment 9217619 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! r=mkmelin
Attachment #9217619 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → 90 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1fc2937a6b81
Fix intermittent test_temporaryFilesRemoved.js by removing IOUtils.stat call. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

There's a warning message in the log:

WARNING: RemoveCurrentDraftMessage can't get draft id: file /builds/worker/checkouts/gecko/comm/mailnews/compose/src/nsMsgCompose.cpp:3423

That code is:

rv = compFields->GetDraftId(getter_Copies(curDraftIdURL));

// Skip if no draft id (probably a new draft msg).
if (NS_SUCCEEDED(rv) && !curDraftIdURL.IsEmpty()) {
  ...
} else {
  NS_WARNING("RemoveCurrentDraftMessage can't get draft id");
}

From a Try run I've established that GetDraftId does succeed but curDraftIdURL is empty.

Not sure if that helps but I figured I might as well write down what I found out.

Seems to me this has been fixed by bug 1751461.

Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1751461]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: