1751461 - Saving draft or sending message may lead to NotAllowedError: Could not remove the file at C:\Users\xxxxx\AppData\Local\Temp\nscopy.tmp in console

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Rachel Martin]

The file is also seen in the said directory, and it is not removed when the application closes. However, it is removed when TB starts again. Seen in TB 97 and trunk using the new JS module for news.

Maybe this is intended behaviour.

Comment 1

[Ping Chen [:rnons] (away)]

I think this is related to MessageSend.jsm, not nntp-js, and it's a windows only problem. The code is at https://searchfox.org/comm-central/rev/44aa77c6da7c13b659667b96eb3c149e2096d0f1/mailnews/compose/src/MessageSend.jsm#1012. I have seen it reported elsewhere but never managed to reproduce it. Can you also reproduce when sending/saving a message with imap/pop3 account?

What if you try to delete it manually by IOUtils.remove() or delete it from File Manager? I'm trying to understand if it's because the file handler is not released after sending.

Comment 2

[Rachel Martin]

To answer your questions: Using TB 97 b2 this also happens when saving a draft for a mail message if the drafts folder is a local folder. Deleting the file from the file manager succeeds, as does await IOUtils.remove("C:\\Users\\rachel\\AppData\\Local\\Temp\\nscopy.tmp"), we checked that the file is really deleted. So it looks like it's still locked when the sending code tries to delete it, but not later when the deletion is executed manually.

It doesn't happen in TB 91 for mail using the new JS send/SMTP modules.

Comment 3

[Ping Chen [:rnons] (away)]

(In reply to Rachel Martin from comment #2)

Using TB 97 b2 this also happens when saving a draft for a mail message if the drafts folder is a local folder.

True, I can reproduce now, but don't know how to fix it.

Comment 4

[Rachel Martin]

It's working in TB 91, what's changed?

Comment 5

[Rachel Martin]

Apologies, we also see the issue in TB 91. Here's our fix:
https://github.com/Betterbird/thunderbird-patches/blob/main/91/bugs/1751461-file-lock.patch
As far as we can see, the files now get deleted and there is no error in the console.

Comment 6

[Ping Chen [:rnons] (away)]

Attachment: 1751461-file-lock.patch

Thanks a lot.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5090da789272
Delay cleanup until OnStopCopy() has run to avoid file locking on Windows. r=mkmelin