170474 - Remove comments in messenger.properties that Inbox, Drafts, Sent, etc. should not be translated

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Hidehiro Kozawa]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.2a) Gecko/20020910 GLU/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.2a) Gecko/20020910 GLU/1.0.4

Because http://bugzilla.mozilla.org/show_bug.cgi?id=57440 was fixed.
comment add acording to http://bugzilla.mozilla.org/show_bug.cgi?id=64199 must
be deleted.

in am-copies.dtd
>><!-- LOCALIZATION NOTE (draftsFolderOn.label): do not translate "Drafts"
>>in below line. see bug #64199 -->
>><!-- LOCALIZATION NOTE (templatesFolderOn.label): do not translate
>>"Templates" in below line. see bug #23625 -->
are same.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Hidehiro Kozawa]

rest of Bug 132826

Comment 2

[Vidar Haarr (not reading bugmail)]

It seems this bug has been fixed:
<http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/locale/en-US/messenger.properties#139>
<http://lxr.mozilla.org/seamonkey/source/mail/locales/en-US/chrome/messenger/messenger.properties#139>

Comment 3

[Hidehiro Kozawa]

Attachment: patch of this bug

Comment 4

[Hidehiro Kozawa]

Comment on attachment 174793 [details] [diff] [review]
patch of this bug

sorry...
I want review for trunk and 1.7branch

Comment 5

[Jungshik Shin]

Comment on attachment 174793 [details] [diff] [review]
patch of this bug

>--- mozilla/mailnews/base/prefs/resources/locale/en-US/am-copies.dtd.old	2003-12-02 10:01:11.000000000 +0900
>+++ mozilla/mailnews/base/prefs/resources/locale/en-US/am-copies.dtd	2005-02-19 23:36:32.902280100 +0900
>@@ -13,17 +13,17 @@
> <!ENTITY templateMailFolder.label "Keep message templates in:">
> <!ENTITY saveMessageDlg.label "Show confirmation dialog when messages are saved">
> <!ENTITY saveMessageDlg.accesskey "S">
>-<!-- LOCALIZATION NOTE (sentFolderOn.label): do not translate "Sent" in below line. see bug #64199 -->

 You have to quote bug 57440 instead of bug 64199. The latter is about blocking
the localization while the former is about enabling it. 
http://lxr.mozilla.org/seamonkey/source/mail/locales/en-US/chrome/messenger/am-
copies.dtd



You also have to fix

Comment 6

[Hidehiro Kozawa]

Attachment: patch v2

jshin:
you're right.

Comment 7

[Jungshik Shin]

Comment on attachment 174844 [details] [diff] [review]
patch v2


>-<!-- LOCALIZATION NOTE (templatesFolderOn.label): do not translate "Templates" in below line. see bug #23625 -->
>+<!-- LOCALIZATION NOTE (templatesFolderOn.label): OK to translate this, bugzilla #23625 -->

The same is true of bug 23625 and bug 6xxxx. Moreover, it's better to use 'bug
#23625' than 'bugzilla #23625 (there may be 23625 installations of bugzilla,
but we're not refering to the 23625th instance of bugzilla here :-)).

I'm sorry I have a second thought. Why do we need 'OK to translate'? Isn't it
better just to get rid of 'LOCAL... NOTE' because by default strings are
localizable?

Comment 8

[Hidehiro Kozawa]

beacause messenger.properties#139 have 'OK' message,
I put these words in am-copies.dtd.

In bug 132826, putting no 'OK' message.
but I think messages are favor at this late date.

Getting rid of messasge both am-copies.dtd and messenger.properties is also good
idea if no one need these message in the now.

Comment 9

[Jungshik Shin]

Comment on attachment 174844 [details] [diff] [review]
patch v2

Ok. For now, let's add 'Ok to translsate' to alert localizers that they're now
allowed to translate strings.

Please, make sure to replace 'bugzilla #.....' with 'bug #.....'. Also, replace
'23625' with '64199'

Comment 10

[Hidehiro Kozawa]

Attachment: updated patch

Comment 11

[Jungshik Shin]

Comment on attachment 175146 [details] [diff] [review]
updated patch

r=jshin

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Checking in mailnews/base/prefs/resources/locale/en-US/am-copies.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/am-copies.dtd,v  <--
 am-copies.dtd
new revision: 1.19; previous revision: 1.18
done
Checking in mail/locales/en-US/chrome/messenger/am-copies.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/am-copies.dtd,v  <-- 
am-copies.dtd
new revision: 1.3; previous revision: 1.2
done